Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312768 - IEGitOperation need to spec whether 'null' is allowed for execute(IProgressMonitor)
Summary: IEGitOperation need to spec whether 'null' is allowed for execute(IProgressMo...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Jens Baumgart CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 06:06 EDT by Remy Suen CLA
Modified: 2010-05-26 09:39 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-05-13 06:06:50 EDT 
This needs to be clearly stated in the javadocs.

I also suggest everyone read SubMonitor's javadoc.
Comment 1 Jens Baumgart CLA 2010-05-25 11:49:33 EDT 
Fix proposed: http://egit.eclipse.org/r/747
Comment 2 Chris Aniszczyk CLA 2010-05-25 12:49:20 EDT 
Merged.
Comment 3 Remy Suen CLA 2010-05-25 12:53:02 EDT 
Change 747 does not actually address the problem in question, that being the execute(IProgressMonitor) method outlined in this bug's summary.
http://egit.eclipse.org/r/#patch,sidebyside,747,1,org.eclipse.egit.core/src/org/eclipse/egit/core/op/IEGitOperation.java

All I see are changes for the getSchedulingRule() method.
Comment 4 Jens Baumgart CLA 2010-05-26 04:35:12 EDT 
Fix proposed: http://egit.eclipse.org/r/750
Comment 5 Matthias Sohn CLA 2010-05-26 09:39:35 EDT 
merged as 8ed98b6d0cd30d8e7b135ddc92650150b446c6d5