Comment 1 Sean Lamers 2010-05-12 19:41:52 EDT

Created attachment 168299 [details]
Patch A - run multiple functions and tools in parallel

This patch includes changes to run multiple functions and tools in parallel during the build (in order to decrease the total build time). The following tools are modified to be non-blocking (via the Linux screen command):

- version check
- copyright check
- bug list and change log generation
- internal package use check
- chkpii
- javadoc

In addition, the patch modifies the calls for fetching build dependencies. Dependencies are downloaded in parallel but unzipped sequentially (I ran into build errors when they were unzipped in parallel - this should be investigated at a later date). Note that changes were also made to account for the fact that the equinox package is now in the form of a p2 repository.

The patch also adds checks for native build failures and moves the verify-plugins.sh call to occur earlier in the build; this will allow the build to fail earlier in the event of a compilation error.

Zip calls are also made quiet (in order to remove log clutter) in addition to other minor changes.

Comment 2 Sean Lamers 2010-05-12 19:43:00 EDT

Joel, please review.

Comment 3 Joel Cayne 2010-05-12 21:05:19 EDT

Created attachment 168306 [details]
Patch A - run multiple functions and tools in parallel

Patch looks good.

Updated with some spacing changes and a modification to the mkdir -p for javadoc/jdiff.

Comment 4 Joel Cayne 2010-05-12 21:13:26 EDT

Patch checked into HEAD.

Comment 5 Sean Lamers 2010-05-12 21:18:31 EDT

Thanks Joel!

Comment 6 Kathy Chan 2010-05-25 14:29:52 EDT

Can this be resolved now for TPTP 4.7?

Comment 7 Joel Cayne 2010-05-31 10:12:17 EDT

Created attachment 170528 [details]
Patch for publishing

Comment 8 Joel Cayne 2010-05-31 10:16:16 EDT

Created attachment 170530 [details]
Patch to remove babel map file

Babel translation has been updated to point to hyades.map file as outlined in http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg03954.html so the babel.map file is no longer needed. It can be removed to save the extra tagging update step in the build.

Comment 9 Sean Lamers 2010-05-31 12:02:24 EDT

Patches look good.

Comment 10 Joel Cayne 2010-05-31 13:23:02 EDT

I would like to request for PMC approval to include the two attached fixes in TPTP v4.7.0.

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

The publishing patch will reduce the checkout of unnecessary files during the build. The babel map is no longer required as the build map (hyades.map) will be used by the babel project.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

No.

5. Who performed the code review?

Sean

6. Is there a test case attached to the bugzilla record?

n/a

7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Low.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
n/a

Comment 11 Kathy Chan 2010-05-31 13:25:31 EDT

Requesting PMC approval for this build improvement for TPTP 4.7.

Comment 12 Sean Lamers 2010-06-14 16:42:03 EDT

Resolving.

Comment 13 Sean Lamers 2010-06-14 16:43:52 EDT

Verified on TPTP-4.7.0-201006081927.