312706 – [breakpoints][tracepoints] The buttons to edit, delete and attach Bp and Tp actions are enabled when created

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312706 - [breakpoints][tracepoints] The buttons to edit, delete and attach Bp and Tp actions are enabled when created

Summary: [breakpoints][tracepoints] The buttons to edit, delete and attach Bp and Tp a...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug (show other bugs)
Version:	7.0
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	7.0
Assignee:	Marc Khouzam
QA Contact:	Ken Ryall

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-05-12 16:18 EDT by Marc Khouzam
Modified:	2010-07-28 15:27 EDT (History)
CC List:	1 user (show)

See Also:

Flags:	marc.khouzam: review? (ken.ryall)

Attachments
Screenshot of problem (35.01 KB, image/png) 2010-05-12 16:18 EDT, Marc Khouzam	no flags	Details
Fix (3.09 KB, patch) 2010-05-12 16:21 EDT, Marc Khouzam	marc.khouzam: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Khouzam

2010-05-12 16:18:47 EDT

Created attachment 168249 [details]
Screenshot of problem

Looking at the snapshot we can see that the Attach, Edit and Delete buttons are enabled even though nothing is selected.  This is not nice and can lead to 

java.lang.ArrayIndexOutOfBoundsException: 0
	at org.eclipse.cdt.debug.ui.breakpointactions.GlobalActionsList.HandleEditButton(GlobalActionsList.java:163)
	at org.eclipse.cdt.debug.ui.breakpointactions.GlobalActionsList$3.widgetSelected(GlobalActionsList.java:112)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1234)

Comment 1 Marc Khouzam

2010-05-12 16:21:43 EDT

Created attachment 168250 [details]
Fix

The fix is pretty simple.

Committed to HEAD.

Comment 2 Marc Khouzam

2010-05-12 16:22:15 EDT

Ken, can you review?

Comment 3 CDT Genie

2010-07-28 15:27:05 EDT

*** cdt cvs genie on behalf of mkhouzam ***
Bug 312706: Update the enablement of the buttons after they are created.

[*] GlobalActionsList.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/breakpointactions/GlobalActionsList.java?root=Tools_Project&r1=1.2&r2=1.3

[*] TracepointGlobalActionsList.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepointactions/TracepointGlobalActionsList.java?root=Tools_Project&r1=1.1&r2=1.2