Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312690 - Patch(es) to remove dependency on PPW Jars
Summary: Patch(es) to remove dependency on PPW Jars
Status: CLOSED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: ETFw (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.0   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 15:06 EDT by Max Billingsley III CLA
Modified: 2010-10-08 13:10 EDT (History)
2 users (show)

See Also:

Attachments
Patches to PPW plugin and feature to remove dependency on external Jars (2.83 KB, application/zip)
2010-05-12 15:06 EDT, Max Billingsley III CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Billingsley III CLA 2010-05-12 15:06:36 EDT 
Created attachment 168236 [details]
Patches to PPW plugin and feature to remove dependency on external Jars

The attached patches (to the plugin and feature, respectively) remove the dependency of the PPW plugins on the external PPW Jars.
Comment 1 Greg Watson CLA 2010-05-15 13:39:28 EDT 
I had to apply these patches by hand so please check they are ok. In future, please generate the patches using Team>Create Patch... on plugins in your workspace. That makes them much easier to apply.

Can the org.eclipse.ptp.etfw.ppw.jars plugin now be removed?

Thanks.
Comment 2 Max Billingsley III CLA 2010-05-17 14:52:28 EDT 
Thanks for applying the patches -- sorry you had to do that by hand.  Everything seems okay to me with the latest CVS version.  The org.eclipse.ptp.etfw.ppw.jars plugin can be removed.

I actually did generate the patches using Team>Create Patch..., but perhaps the problem was that I had changed the name of the projects in my workspace because of a name clash on my end.  Thus I see at the top of the patch:

  ### Eclipse Workspace Patch 1.0
  #P org.eclipse.ptp.etfw.ppw_FROMCVS

Just for future reference, was this likely the problem?

(I'm leaving the bug open until org.eclipse.ptp.etfw.ppw.jars is removed.)
Comment 3 Greg Watson CLA 2010-05-26 15:18:50 EDT 
The org.eclipse.ptp.etfw.ppw.jars plugin has been moved to tools/old.
 
The patch wouldn't apply, presumably because of the name change. I guess avoiding changing the name in the future would help.

Closing bug as fixed. The changes are in RC2 so please test.
Comment 4 Beth Tibbitts CLA 2010-10-08 13:10:24 EDT 
Max I am assuming this is fixed to your satisfaction; closing and marking for 4.0