Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312684 - Image leak on the library provider install panel
Summary: Image leak on the library provider install panel
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 14:30 EDT by Karen Butzke CLA
Modified: 2010-05-17 12:06 EDT (History)
1 user (show)

See Also:
konstantin: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
konstantin: pmc_approved? (naci.dai)
konstantin: pmc_approved? (deboer)
konstantin: pmc_approved? (neil.hauge)
konstantin: pmc_approved? (kaloyan)

Attachments
proposed patch - disposes image (1006 bytes, patch)
2010-05-12 14:31 EDT, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2010-05-12 14:30:12 EDT 
There is an image leak on the osgi library provider install panel.  I found this because I got an SWT no more handles exception and eclipse crashed.  Wasn't necessarily fully caused by this leak, but helped to contribute to it.  I was creating JPA projects and modifying their properties, both of which use the library provider install panel. I will attach a patch that disposes of the image.
Comment 1 Karen Butzke CLA 2010-05-12 14:31:34 EDT 
Created attachment 168222 [details]
proposed patch - disposes image
Comment 2 Konstantin Komissarchik CLA 2010-05-12 20:56:03 EDT 
Thanks for the patch. Looks correct. Raising for PMC approval.

    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Resource leak that can lead crash of Eclipse process.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manual testing.

    * Give a brief technical overview. Who has reviewed this fix? 

One of the allocated images was not disposed.

    * What is the risk associated with this fix? 

No risk.
Comment 3 Konstantin Komissarchik CLA 2010-05-17 12:06:04 EDT 
Released patch to 3.2 RC2 stream and fproj codeline. Thanks!