Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312640 - JAX-RS facet - Extraneous spacing needs to be removed.
Summary: JAX-RS facet - Extraneous spacing needs to be removed.
Status: RESOLVED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 11:02 EDT by Keith Chong CLA
Modified: 2010-05-13 23:13 EDT (History)
2 users (show)

See Also:
keith.chong.ca: pmc_approved? (david_williams)
keith.chong.ca: pmc_approved? (raghunathan.srinivasan)
keith.chong.ca: pmc_approved? (naci.dai)
keith.chong.ca: pmc_approved? (deboer)
neil.hauge: pmc_approved+
keith.chong.ca: pmc_approved? (kaloyan)
ericdp: review+

Attachments
Screen cap of JAX-RS Facet Install Page with spacing problem (28.44 KB, image/x-png)
2010-05-12 11:03 EDT, Keith Chong CLA 		no flags Details
Patch for org.eclipse.jst.ws.jaxrs.ui (2.77 KB, patch)
2010-05-12 11:19 EDT, Keith Chong CLA 		no flags Details | Diff
Screen cap of page with spacing removed (27.98 KB, image/x-png)
2010-05-12 11:20 EDT, Keith Chong CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2010-05-12 11:02:06 EDT 
An adopter is requesting that the spacing between the library panel and the Include with application options should be removed.

The spacing is unnecessary, and makes the dialog unprofessional looking for the product.

See screen cap of the spacing.
Comment 1 Keith Chong CLA 2010-05-12 11:03:02 EDT 
Created attachment 168161 [details]
Screen cap of JAX-RS Facet Install Page with spacing problem
Comment 2 Keith Chong CLA 2010-05-12 11:19:25 EDT 
Created attachment 168166 [details]
Patch for org.eclipse.jst.ws.jaxrs.ui
Comment 3 Keith Chong CLA 2010-05-12 11:20:00 EDT 
Created attachment 168167 [details]
Screen cap of page with spacing removed
Comment 4 Keith Chong CLA 2010-05-12 11:33:19 EDT 
1. Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

An adopter is requesting this fix.  See comment #1 above.

2. Is there a work-around? If so, why do you believe the work-around is insufficient? 

There is no work-around.

3. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Patch tested  manually.  No test case is necessary since it's just removing spacing in the UI.

4. Give a brief technical overview. Who has reviewed this fix? 
What is the risk associated with this fix? 

Low risk.  I've come across many problems where extraneous spacing is added due to mis-parenting of widgets.  This is another example.  The fix is simply to parent them properly, and lay out the children of the composite accordingly.

Patch also includes removal of unused imports.

I will ask Eric to review this patch.  Pending his review, I will then put forth for PMC approval.
Comment 5 Eric Peters CLA 2010-05-12 11:47:08 EDT 
Patch looks good, I agree the spacing looks really bad.
Comment 6 Keith Chong CLA 2010-05-12 12:02:23 EDT 
Marking for PMC approval for 3.2 RC1.

See Comment #4 for details.
Comment 7 Keith Chong CLA 2010-05-13 14:13:11 EDT 
Fix resolved and in this week's RC1 build.