Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312502 - AbstractAddRowHandler simplification
Summary: AbstractAddRowHandler simplification
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Holger Voormann CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 16:14 EDT by Igor Jacy Lino Campista CLA
Modified: 2011-11-09 17:36 EST (History)
2 users (show)

See Also:

Attachments
Patch with the simplification (4.93 KB, patch)
2010-05-11 16:22 EDT, Igor Jacy Lino Campista CLA 		eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Jacy Lino Campista CLA 2010-05-11 16:14:20 EDT 
The abstract class AbstractAddRowHandler in essense addeds a row to the VEX widget.
It does it by managing two lists for one concept (A relation of row to many cells).

A simplication idea is to extract that concept of RowCell and have a unique list.
Comment 1 Igor Jacy Lino Campista CLA 2010-05-11 16:22:35 EDT 
Created attachment 168027 [details]
Patch with the simplification

I will check about the test to the logic.
Comment 2 Holger Voormann CLA 2010-05-17 13:04:23 EDT 
(In reply to comment #1)
Looks good.

Patch reviewed and applied (with minor changes: RowCells class: => static, fields: => final; getters removed).

Igor, thank you for this contribution.
Comment 3 Holger Voormann CLA 2010-05-17 16:10:01 EDT 
(In reply to comment #1)
> I will check about the test to the logic.
>
Sorry, I overlooked your comment. Of course, tests are always welcome and we should have more of them. If you have a test please attach it.
Comment 4 Florian Thienel CLA 2011-06-02 05:23:28 EDT 
Closing resolved bugs.
Comment 5 Florian Thienel CLA 2011-11-09 17:36:26 EST 
Moved to Mylyn Docs Vex.