Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312500 - Bad array index in MirrorApplication
Summary: Bad array index in MirrorApplication
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 16:08 EDT by Peter Nehrer CLA
Modified: 2010-05-17 09:52 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Nehrer CLA 2010-05-11 16:08:11 EDT 
I've been trying to decypher the cmd line args for MirrorApplication and discovered the following dubious-looking code:

org.eclipse.equinox.p2.internal.repository.tools.MirrorApplication, Line 275:

				VersionRange range = segments.length > 1 ? new VersionRange(segments[i]) : null;

I'd imagine the segments[i] should be segments[1]. In any case this doesn't work for the first element in the rootIUs array as you're referring to the IU's id and not the version range (which should follow the /, I guess).

This is from a 3.6M7 install.
Comment 1 Pascal Rapicault CLA 2010-05-11 21:44:59 EDT 
Fixed in HEAD.
Comment 2 Thomas Watson CLA 2010-05-17 09:52:06 EDT 
Is this in RC1 or RC2?  Please get the change reviewed.  Do not back out, just get it reviewed.