Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312499 - Host OSGi console does not work after disconnect
Summary: Host OSGi console does not work after disconnect
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 16:01 EDT by Darin Wright CLA
Modified: 2010-05-12 13:58 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+

Attachments
patch to not reuse a closed ConsoleSession (2.27 KB, patch)
2010-05-11 17:50 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2010-05-11 16:01:42 EDT 
Follow up to bug 311307.

Similar to the Java Stack Trace console, I think the Host OSGi console should have a close button/action. It would be nice to be able to open/close the console.

I noticed that typing "disconnect" into the console closes it, but this is not very intuitive. As well, once disconnected, it does not seem possible to re-connect. Is this an OSGi limitation? If so, is ther someway we can tell the user that the connection is closed and is not useable?
Comment 1 Thomas Watson CLA 2010-05-11 17:50:21 EDT 
Created attachment 168052 [details]
patch to not reuse a closed ConsoleSession

With the changes in bug 311307 PDE is now reusing the same ConsoleSession instance when it attempts to reopen the OSGi Console.  After the method org.eclipse.osgi.framework.console.ConsoleSession.doClose() is called the ConsoleSession should not be used again.  Instead a new ConsoleSession should be created by the factory.

Here is a patch that attempts to fix this.
Comment 2 Darin Wright CLA 2010-05-12 13:58:51 EDT 
Thanks, Tom. This makes the console work for the "disconnect"/re-open scenario. +1. I'll open a new bug to add a close action/toolbar buttun (again :-)