Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312475 - JUnit failures in metadata and pagedesigner tests
Summary: JUnit failures in metadata and pagedesigner tests
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Gerry Kessler CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 13:46 EDT by Raghunathan Srinivasan CLA
Modified: 2017-12-19 13:27 EST (History)
2 users (show)

See Also:
raghunathan.srinivasan: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
cameron.bateman: review+


Attachments
Fix (11.02 KB, patch)
2010-05-11 17:59 EDT, Gerry Kessler CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raghunathan Srinivasan CLA 2010-05-11 13:46:21 EDT
See test log:  http://build.eclipse.org/webtools/committers/wtp-R3.2.0-I/20100511060448/I-3.2.0-20100511060448/testResults.php

The following exception is common to all the failures.

Cannot add null resource

java.lang.NullPointerException: Cannot add null resource
at org.eclipse.jst.jsf.common.internal.resource.LifecycleListener.addResource(LifecycleListener.java:200)
at org.eclipse.jst.jsf.common.internal.resource.ResourceSingletonObjectManager.manageResource(ResourceSingletonObjectManager.java:157)
at org.eclipse.jst.jsf.common.internal.resource.ResourceSingletonObjectManager.getInstance(ResourceSingletonObjectManager.java:92)
at org.eclipse.jst.jsf.common.metadata.internal.MetaDataModelManagerFactory.getMetaDataModelManagerInstance(MetaDataModelManagerFactory.java:56)
at org.eclipse.jst.jsf.common.metadata.query.TaglibDomainMetaDataQueryHelper.getMDModel(TaglibDomainMetaDataQueryHelper.java:203)
at org.eclipse.jst.jsf.common.metadata.query.TaglibDomainMetaDataQueryHelper.getModel(TaglibDomainMetaDataQueryHelper.java:90)
at org.eclipse.jst.jsf.common.metadata.query.TaglibDomainMetaDataQueryHelper.getEntities(TaglibDomainMetaDataQueryHelper.java:123)
at org.eclipse.jst.jsf.common.metadata.query.TaglibDomainMetaDataQueryHelper.getEntity(TaglibDomainMetaDataQueryHelper.java:101)
at org.eclipse.jst.jsf.common.metadata.tests.TraitValueHelperTests.setUp(TraitValueHelperTests.java:42)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:209)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:35)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:31)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
at org.eclipse.equinox.launcher.Main.main(Main.java:1383)
Comment 1 Gerry Kessler CLA 2010-05-11 17:59:55 EDT
Created attachment 168054 [details]
Fix

Ensures that md model manager for null projects are unmanaged resources.
Comment 2 Cameron Bateman CLA 2010-05-11 18:05:36 EDT
Looks good.
Comment 3 Raghunathan Srinivasan CLA 2010-05-11 18:51:36 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
The patch addresses the test failures that was caused by recent changes to the code which in turn exposed an issue in our test code.
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
NO workaround
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Local execution of the failing Junit tests
* Give a brief technical overview. Who has reviewed this fix? 
See comment 2
* What is the risk associated with this fix?
none.
Comment 4 Gerry Kessler CLA 2010-05-12 13:03:22 EDT
Released to HEAD 5/12/10
Comment 5 Eclipse Genie CLA 2017-12-18 20:15:33 EST
New Gerrit change created: https://git.eclipse.org/r/114215