Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312470 - Helios train requires Photran to use message bundles
Summary: Helios train requires Photran to use message bundles
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.For Internal Use (show other bugs)
Version: 5.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P2 enhancement (vote)
Target Milestone: 6.0   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 314779
  Show dependency tree
 
Reported: 2010-05-11 13:25 EDT by Jeffrey Overbey CLA
Modified: 2010-06-01 16:43 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Overbey CLA 2010-05-11 13:25:22 EDT 
As part of the Helios train requirements, Photran needs to be converted to use message bundles rather than literal strings for UI messages.
Comment 1 Jeffrey Overbey CLA 2010-05-17 18:25:26 EDT 
org.eclipse.photran.cdtinterface converted, and compiler settings adjusted to give errors on non-externalized strings
Comment 2 Jeffrey Overbey CLA 2010-05-17 18:59:42 EDT 
org.eclipse.photran.cdtinterface.vpg done
Comment 3 Jeffrey Overbey CLA 2010-05-17 22:38:25 EDT 
org.eclipse.photran.core done
org.eclipse.photran.ui done
Comment 4 Jeffrey Overbey CLA 2010-05-27 16:29:05 EDT 
The conversion is almost entirely done.

I am waiting to commit the changes to the photran.ui.vpg project since Mariano has a number of changes out.

The only project I will not be able to convert is photran.core.vpg.  There are a few outstanding patches on that project, and it contains generated code... also there are more than 1,000 literal strings... so that's more than I can deal with this late in the game.  Luckily, not externalizing it will only affect a few error messages and some of the UI for refactorings.  The vast majority of the UI is (obviously) in the UI plug-ins, which are externalized, so I think this will put us in good shape for Helios.

I need to add info about externalization to the Developer's Guide.
Comment 5 Jeffrey Overbey CLA 2010-05-27 17:07:16 EDT 
I filed Bug 314779 on the core.vpg project.
Comment 6 Jeffrey Overbey CLA 2010-06-01 16:43:45 EDT 
I figured out how to suppress errors/warnings in the generated code, so I decided to bite the bullet and externalize all the strings in core.vpg.  Thanks to Ashley Kasza for helping with it (Bug 314779).

Photran is now completely externalized (except for the tests, for which it obviously doesn't matter).