Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312466 - early call to modify bundle root leaves WorkspacePluginModelManager un-initialized
Summary: early call to modify bundle root leaves WorkspacePluginModelManager un-initia...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 12:56 EDT by Darin Wright CLA
Modified: 2010-05-11 14:13 EDT (History)
2 users (show)

See Also:
curtis.windatt.public: review+

Attachments
patch (858 bytes, patch)
2010-05-11 12:57 EDT, Darin Wright CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2010-05-11 12:56:26 EDT 
It's possible to use the IBundleProjectService to set the root of a bundle. If this is done before the PDE model managers are initialized, it can leave the WorkspacePluginModelManager in an un-initialized state.

It results in a call to 'removeModel(...)', and 'createModel(...)', which will quietly initlaize 'fModels' to a hashtable, and the next call to 'initialize()' will be ignored since 'fModels' is no longer null. The result is that the model manager is not hooked up to listen to resource deltas.
Comment 1 Darin Wright CLA 2010-05-11 12:57:16 EDT 
Created attachment 167972 [details]
patch
Comment 2 Darin Wright CLA 2010-05-11 13:11:50 EDT 
Please review, Curtis.
Comment 3 Curtis Windatt CLA 2010-05-11 14:13:55 EDT 
+1 Fixed in HEAD.