Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312427 - Launch groups should have better validation/filtering of referenced launch configuration
Summary: Launch groups should have better validation/filtering of referenced launch co...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 6.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Elena Laskavaia CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 09:57 EDT by Teodor Madan CLA
Modified: 2010-07-28 15:26 EDT (History)
2 users (show)

See Also:
elaskavaia.cdt: review+

Attachments
Improve validation fix (6.77 KB, patch)
2010-05-11 10:05 EDT, Teodor Madan CLA 		elaskavaia.cdt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Teodor Madan CLA 2010-05-11 09:57:43 EDT 
Build Identifier: CDT 6.0

User is not warned of having references to invalid launch configuration. This can commonly happen when having a big pool of launches that depend on some projects that might be closed (intentionally or not).

Another minor issue is that if C/C++ launches are filtered with capabilities, user still will see them when adding a new launch configuration to the launch group.

Reproducible: Always

Steps to Reproduce:
1. Create a C++ new project (e.g. test)
2. Create a C/C++ Application launch named (e.g. test.launch)
3. Create a new "Launch Group" launch. Add previous launch "test.launch" into the group launch.
4. Close test project.
5. Open debug settings for the "Launch Group" launch. Noticed that launch configuration appears to be valid (no error details on top of the dialog). Also there's no hint that test.launch is the problem.
Comment 1 Teodor Madan CLA 2010-05-11 10:05:33 EDT 
Created attachment 167923 [details]
Improve validation fix

Attached fix will: 
- not show launch configurations that are filtered-out through capabilities
- hitting edit on invalid launch would not work
- Mark the launch as not valid if there's at least one checked launch configuration that either is filtered /deleted or is not a valid (e.g. closed project). 
- Set error icon to each invalid launch configuration reference.

User still can reference stale/wrong launch configuration but have to uncheck the corresponding entry.
Comment 2 Elena Laskavaia CLA 2010-05-11 10:35:09 EDT 
patch reviewed - ok (you have commit right already right?)
Comment 3 Teodor Madan CLA 2010-05-11 11:09:08 EDT 
(In reply to comment #2)
> patch reviewed - ok (you have commit right already right?)

Thank you. 

I do not have cvs write access yet. waiting paperwork processing.
Comment 4 Elena Laskavaia CLA 2010-05-11 12:25:55 EDT 
applied on trunk