Community
Participate
Working Groups
Created attachment 167915 [details] v1.0 the publish cache has a method that is supposed to return true if the publish cache and the module list are different. This method assumes that all objects are the same and just compares the sizes of the array. The correct implementation should be to compare the size of the array first, and if arrays are the same size then further compare the objects inside to ensure that all objects are the same.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is a major function for adopters to display that there is changes on the server and that they need to republish the app, in certain scenarios * Is there a work-around? If so, why do you believe the work-around is insufficient? no workaround * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? I tested the function using a few publish scenarios * Give a brief technical overview. Who has reviewed this fix? The function was incorrect on just checking the size of the arrays, checking the size of the arrays, is insufficient to compare that two objects are the same. * What is the risk associated with this fix? low as the old function was kept untouched, but we are now doing further processing
The reason for the change looks OK. Patch looks correct too, but I have a question on the code. Why an array of a single boolean value is used for a flag? Doesn't a simple boolean variable work well too? Just wondering...
Kayolan, In this case, I haven't studied the reasons enough to give you a smart answer. I am mainly following my predecessor coding style :).
changes committed to HEAD
Changes released to HEAD
New Gerrit change created: https://git.eclipse.org/r/108943
