Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312392 - NPE in ExtendedClassValidation
Summary: NPE in ExtendedClassValidation
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 06:13 EDT by Nicolas Bros CLA
Modified: 2010-10-04 12:58 EDT (History)
3 users (show)

See Also:
nicolas.bros: helios+
hugo.bruneliere: review+

Attachments
patch (3.39 KB, patch)
2010-05-11 06:24 EDT, Nicolas Bros CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2010-05-11 06:13:15 EDT 
An NPE occurs because FacetPlugin.getDefault() returns null:

java.lang.NullPointerException
at org.eclipse.gmt.modisco.infra.facet.validation.ExtendedClassValidation.validate(ExtendedClassValidation.java:63)
at org.eclipse.emf.validation.internal.util.JavaConstraintParser$ConstraintAdapter.validate(JavaConstraintParser.java:80)
at org.eclipse.emf.validation.internal.service.AbstractValidator.evaluateConstraints(AbstractValidator.java:241)
at org.eclipse.emf.validation.internal.service.BatchValidator.validate(BatchValidator.java:264)
at org.eclipse.emf.validation.internal.service.BatchValidator.validate(BatchValidator.java:211)
at org.eclipse.emf.validation.internal.service.BatchValidator.doValidate(BatchValidator.java:149)
at org.eclipse.emf.validation.internal.service.AbstractValidator.validate(AbstractValidator.java:147)
at org.eclipse.emf.validation.internal.service.AbstractValidator.validate(AbstractValidator.java:126)
at org.eclipse.emf.validation.internal.service.BatchValidator.validate(BatchValidator.java:117)
at org.eclipse.gmt.modisco.infra.facet.validation.EValidatorAdapter.validate(EValidatorAdapter.java:62)
at org.eclipse.emf.ecore.util.Diagnostician.validate(Diagnostician.java:165)
at org.eclipse.emf.ecore.util.Diagnostician.validate(Diagnostician.java:143)
at org.eclipse.emf.ecore.util.Diagnostician.validate(Diagnostician.java:114)
at org.eclipse.gmt.modisco.infra.common.core.internal.validation.ValidationJob.validateItem(ValidationJob.java:170)
at org.eclipse.gmt.modisco.infra.common.core.internal.validation.ValidationJob.validateSync(ValidationJob.java:143)
at org.eclipse.gmt.modisco.infra.common.core.internal.builder.AbstractMoDiscoCatalog.openResource(AbstractMoDiscoCatalog.java:310)
at org.eclipse.gmt.modisco.infra.common.core.internal.builder.AbstractMoDiscoCatalog.internalAddWSFile(AbstractMoDiscoCatalog.java:713)
at org.eclipse.gmt.modisco.infra.common.core.internal.builder.AbstractMoDiscoCatalog$4.run(AbstractMoDiscoCatalog.java:756)
at org.eclipse.gmt.modisco.infra.common.core.internal.builder.CatalogJob.run(CatalogJob.java:52)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Nicolas Bros CLA 2010-05-11 06:24:07 EDT 
Created attachment 167888 [details]
patch
Comment 2 Hugo Bruneliere CLA 2010-05-11 10:11:18 EDT 
Nicolas,

You can go ahead with this patch.

Regards,

Hugo
Comment 3 Nicolas Bros CLA 2010-05-11 10:30:40 EDT 
Thank you. I have applied the patch to 0_8_0.
Comment 4 Hugo Bruneliere CLA 2010-10-04 12:58:05 EDT 
The patch has been successfully applied.