Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312357 - setting the review flag on eclipse.org did not work in Mylyn
Summary: setting the review flag on eclipse.org did not work in Mylyn
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.4   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 19:45 EDT by Shawn Minto CLA
Modified: 2010-09-14 14:20 EDT (History)
3 users (show)

See Also:
eclipse: documentation-


Attachments
commited patch (6.18 KB, patch)
2010-05-30 14:03 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (960 bytes, application/octet-stream)
2010-05-30 14:03 EDT, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2010-05-10 19:45:26 EDT
I tried flagging a bug with a + for review, but it did not get set when I submitted the bug.  I then tried in the web ui and it worked as expected.
Comment 1 Frank Becker CLA 2010-05-24 03:31:51 EDT
(In reply to comment #0)
> I tried flagging a bug with a + for review, but it did not get set when I
> submitted the bug.  I then tried in the web ui and it worked as expected.

Sorry I can not reproduce this on my local Bugzilla installation. Can you reproduce this?
Can you please give me more details.
1) what bugzilla version did you use?
2) what is the type of the flag (I did my tests with requestable (specifically) multiplicable)
3) do you know if grant / request groups are set?
Comment 2 Steffen Pingel CLA 2010-05-24 14:57:35 EDT
I just tried setting the review flag to "+" on this Eclipse.org bug but it didn't do anything. It does work for attachments though.
Comment 3 Frank Becker CLA 2010-05-30 08:06:30 EDT
test review flag to "+" from mylyn.
Comment 4 Frank Becker CLA 2010-05-30 14:03:18 EDT
Created attachment 170479 [details]
commited patch

I only add a test for the type of the flag.
Mylyn has fetched the review flag of the attachment and not of the bug.
Comment 5 Frank Becker CLA 2010-05-30 14:03:21 EDT
Created attachment 170480 [details]
mylyn/context/zip
Comment 6 Frank Becker CLA 2010-05-30 14:04:48 EDT
Please verify!
Comment 7 Eike Stepper CLA 2010-09-13 03:35:29 EDT
There seems to be a regression since last week's builds...
Comment 8 Steffen Pingel CLA 2010-09-13 03:38:52 EDT
Flag related tests seem to be failing, too: http://mylyn.eclipse.org/hudson/job/mylyn-test-e3.5/75/testReport/

Frank, could you take a look?
Comment 9 Frank Becker CLA 2010-09-13 16:33:48 EDT
(In reply to comment #8)
> Flag related tests seem to be failing, too:
> http://mylyn.eclipse.org/hudson/job/mylyn-test-e3.5/75/testReport/
> 
> Frank, could you take a look?

Yes, but I can not do this before the next weekend.
Comment 10 Steffen Pingel CLA 2010-09-14 14:20:27 EDT
I have committed a fix as part of bug 322081.