Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312345 - [JSF2.0] MyFaces 2.0 not supported
Summary: [JSF2.0] MyFaces 2.0 not supported
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Cameron Bateman CLA
QA Contact:
URL:
Whiteboard: PMC_approved JSF2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 17:46 EDT by Cameron Bateman CLA
Modified: 2010-05-25 14:43 EDT (History)
5 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
deboer: pmc_approved+
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: review+


Attachments
Ensures that standard taglibs are loaded if they are not found on the classpath. (688.42 KB, patch)
2010-05-24 11:23 EDT, Cameron Bateman CLA
no flags Details | Diff
Test coverage (9.96 KB, patch)
2010-05-24 11:23 EDT, Cameron Bateman CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Bateman CLA 2010-05-10 17:46:08 EDT
The MyFaces implementation does not bundle .taglib.xml files in their jars to define the standard tags.  We do not currently have a way in Helios to add them, so development with MyFaces libs (as opposed to the RI libs) will be limited.
Comment 1 Yury Kats CLA 2010-05-11 14:31:34 EDT
Tooling for standard tags should not depend on JSF implementations packaging taglib.xml. This is not required by JSF spec and is up to the implementation authors.

Tooling for standard tags should be self-contained as all information about those tags is spec'ed and thus is available.

Not supporting MyFaces is a big deal. I would mark this as "critical", not "normal".
Comment 2 Nitin Dahyabhai CLA 2010-05-17 13:52:58 EDT
(In reply to comment #1)
> Not supporting MyFaces is a big deal. I would mark this as "critical", not
> "normal".

That's not what that means.  https://bugs.eclipse.org/bugs/page.cgi?id=fields.html#bug_severity
Comment 3 Yury Kats CLA 2010-05-17 13:56:12 EDT
ok, major if you insist.
Comment 4 Cameron Bateman CLA 2010-05-24 11:23:34 EDT
Created attachment 169681 [details]
Ensures that standard taglibs are loaded if they are not found on the classpath.
Comment 5 Cameron Bateman CLA 2010-05-24 11:23:56 EDT
Created attachment 169682 [details]
Test coverage
Comment 6 Raghunathan Srinivasan CLA 2010-05-24 19:18:08 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
This is a stop-ship bug. JSF 2.0 features are not supported for the MyFaces 2.0 implementation which is a major blocker for adopters and users.
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
No workaround.
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Junit test attached.
* Give a brief technical overview. Who has reviewed this fix? 
See  description and comment 4. The fix bundles the taglib.xml from the RI implementation and loads it if not found in the classpath.
* What is the risk associated with this fix?
medium
Comment 7 Cameron Bateman CLA 2010-05-25 14:43:30 EDT
Patches applied to HEAD (3.2M3)