Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312342 - TVT36:TCT209: JPN: Missing Attach button on New Tracepoint Action dialog
Summary: TVT36:TCT209: JPN: Missing Attach button on New Tracepoint Action dialog
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 17:36 EDT by CDE Administration CLA
Modified: 2010-07-28 15:58 EDT (History)
4 users (show)

See Also:
vivkong: review+


Attachments
06.000.228.gif (86.55 KB, image/gif)
2010-05-10 17:36 EDT, CDE Administration CLA
no flags Details
screenshot (22.89 KB, image/png)
2010-05-11 10:48 EDT, Vivian Kong CLA
no flags Details
Fix to resize the window to make sure buttons are all visible (1.63 KB, patch)
2010-05-12 11:25 EDT, Marc Khouzam CLA
marc.khouzam: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description CDE Administration CLA 2010-05-10 17:36:26 EDT
<response_by> Keiko Terada at 2010.05.09.23.24.27 </response_by>
NLS Build Label: 20100506-1500
Language: Japanese
Must-Fix: Yes

Problem description:
"Attach" button is shown under "Available actions:" in English, but it is not shown in Japanese.

----------------
Procedure:
Select Window > Preferences from the main menu
Select General > Capabilities in the tree view, on the left side of the Preferences window
Check the checkboxes next to all capabilities containing CDT
Click the OK button to close the Preferences window
Select Window > Preferences from the main menu
Select C/C++ > Debug > Tracepoint Actions in the tree view, on the left side of the Preferences window
Click New
From the Action Type drop down menu, select While-Stepping Action
Verify
Click Cancel to exit the New Tracepoint Action window
Click Cancel to exit the C/C++ Preferences window

<response_by> igultek at 2010.05.10.16.23.51 </response_by>
This article was reassigned from Category:''TVT/Testing,Inbox''.
Comment 1 CDE Administration CLA 2010-05-10 17:36:32 EDT
Created attachment 167827 [details]
06.000.228.gif
Comment 2 CDE Administration CLA 2010-05-10 17:36:36 EDT
<cde:tctdetail>
Testcase: 06.000.228 - CDT - C/C++ PREFERENCES
Project: WSW36
Component: Xfer - CDT/cdt-build
Priority: 2
Subject: JPN: Missing Attach button on New Tracepoint Action dialog
Article ID: 209
Originator: terak@jp.ibm.com
</cde:tctdetail>
Comment 3 Marc Khouzam CLA 2010-05-11 10:41:19 EDT
The window is too small.  If you make the window larger from the bottom, the buttons will become visible.
Comment 4 Vivian Kong CLA 2010-05-11 10:48:38 EDT
Created attachment 167933 [details]
screenshot

You need to make the dialog bigger.  Here's what it should look like and the Attach button is there
Comment 5 Vivian Kong CLA 2010-05-11 10:50:12 EDT
Resize the dialog and the button will appear.
Comment 6 Kit Lo CLA 2010-05-11 13:37:46 EDT
I believe the reporter saw the problem when the dialog was launched in its default size. There is no indication that the dialog is not big enough (like scroll bars or "...' or anything). I'm afraid the some users may not know that we have to resize the dialog to see the buttons. Is there any way to make the default size bigger?
Comment 7 CDE Administration CLA 2010-05-11 20:20:56 EDT
<response_by> Keiko Terada at 2010.05.11.19.11.36 </response_by>
Since OK and Cancel buttons are shown, users will see the diqalog is enough big to see whole contents. As kit commented, users may not notice to resize the dialog.

Could you expand the height of the dialog?
Comment 8 Marc Khouzam CLA 2010-05-11 21:09:32 EDT
(In reply to comment #7)
> <response_by> Keiko Terada at 2010.05.11.19.11.36 </response_by>
> Since OK and Cancel buttons are shown, users will see the diqalog is enough big
> to see whole contents. As kit commented, users may not notice to resize the
> dialog.
> 
> Could you expand the height of the dialog?

Ok, I'll write a fix for that
Comment 9 Marc Khouzam CLA 2010-05-12 11:25:20 EDT
Created attachment 168168 [details]
Fix to resize the window to make sure buttons are all visible

Thsi patch resizes the window to make sure buttons are all visible.
Committed to HEAD.
Comment 10 Marc Khouzam CLA 2010-05-12 11:25:49 EDT
Vivian can you review?
Comment 11 Vivian Kong CLA 2010-05-12 13:22:40 EDT
Looks good.  Thanks Marc.
Comment 12 CDE Administration CLA 2010-05-12 16:36:01 EDT
<response_by> rewagner at 2010.05.12.15.22.58 </response_by>
Testers:  Please verify and close thread if fix worked in new build.
Comment 13 CDE Administration CLA 2010-05-13 01:35:52 EDT
<response_by> Keiko Terada at 2010.05.13.00.28.47 </response_by>
I will verify in the new build after 20100512-1300 as it does not contain the fix yet.
Comment 14 CDE Administration CLA 2010-05-14 04:51:11 EDT
<response_by> Keiko Terada at 2010.05.14.03.37.07 </response_by>
I verified the fix in 20100513-1500. Thanks!
Comment 15 CDT Genie CLA 2010-07-28 15:26:59 EDT
*** cdt cvs genie on behalf of mkhouzam ***
Bug 312342: Make sure the dialog window size is big enough to show all its content.

[*] TracepointActionDialog.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepointactions/TracepointActionDialog.java?root=Tools_Project&r1=1.1&r2=1.2
Comment 16 CDE Administration CLA 2010-07-28 15:58:15 EDT
[Added by CDE: Completed by the CDE Bridge]