Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312324 - [jSLP] Change license from BSD to EPL
Summary: [jSLP] Change license from BSD to EPL
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.protocols (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 15:35 EDT by Markus Kuppe CLA
Modified: 2010-06-03 07:14 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (3.98 KB, application/octet-stream)
2010-06-03 07:14 EDT, Markus Kuppe CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2010-05-10 15:35:26 EDT 
BSD licenses headers have to replaced with EPL equivalents.
Comment 1 Markus Kuppe CLA 2010-06-03 06:11:28 EDT 
A cleamroom impl of org.eclipse.ecf/protocols/bundles/ch.ethz.iks.slp/src/main/java/ch/ethz/iks/slp/ServiceType.java has been committed to HEAD to replace old impl.
Comment 2 Markus Kuppe CLA 2010-06-03 06:28:00 EDT 
Error: file /opt/hudson/jobs/C-HEAD-discovery.slp.feature/workspace/projects/ch.ethz.iks.slp/src/main/java/ch/ethz/iks/slp/ServiceType.java, line 24: The method ch.ethz.iks.slp.ServiceType.isServiceURL() has been removed
Error: file /opt/hudson/jobs/C-HEAD-discovery.slp.feature/workspace/projects/ch.ethz.iks.slp/META-INF/MANIFEST.MF, line 4: The major version should be incremented in version 1.1.0.qualifier, since API breakage occurred since version 1.1.0.v20100220-1625

Is there a reason why isServiceURL has been removed?
Comment 3 Jan S. Rellermeyer CLA 2010-06-03 06:47:07 EDT 
> Is there a reason why isServiceURL has been removed?

Yes, because it was bogus from the very beginning. If you want to keep it and avoid the formal API breakage, implement it by always returning true. I do not permit any more to create ServiceType objects for invalid service types so this method makes no sense at all and I doubt that anybody in the world has ever used it.
Comment 4 Markus Kuppe CLA 2010-06-03 07:14:17 EDT 
Readded isServiceURL(...) for API compatibility. Marking as FIXED
Comment 5 Markus Kuppe CLA 2010-06-03 07:14:19 EDT 
Created attachment 170931 [details]
mylyn/context/zip