Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312307 - [validation] ValidatorStrategy triggering unwanted plug-in activation
Summary: [validation] ValidatorStrategy triggering unwanted plug-in activation
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.0.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-05-10 13:29 EDT by Nick Sandonato CLA
Modified: 2010-05-21 08:33 EDT (History)
4 users (show)

See Also:
thatnitind: review+

Attachments
patch (1.64 KB, patch)
2010-05-10 13:51 EDT, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-05-10 13:29:12 EDT 
+++ This bug was initially created as a clone of Bug #262151 +++

The org.eclipse.wst.sse.ui.internal.reconcile.validator.ValidatorStrategy in the reconcile method is calling an internal validation framework method:

IValidator iv = v.asIValidator();

This call triggers that validator's plug-in to be activated. Since this is being called on all the disabled validators, it is causing all the validation plug-ins to load.

If I provided you with a method, so that you could first tell if the validator was activated, could you make use of it to not call this asIValidator() ?
Comment 1 Nick Sandonato CLA 2010-05-10 13:51:24 EDT 
Created attachment 167768 [details]
patch

This patch removes code that would cause activation of plug-ins due to instantiating Validators.
Comment 2 Nick Sandonato CLA 2010-05-10 13:51:42 EDT 
Nitin, could you please review for 3.0.5p?
Comment 3 Carl Anderson CLA 2010-05-21 08:33:07 EDT 
Committed to R3_0_5_patches