Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312286 - Plug-in problem gives an error for a valid Manifest
Summary: Plug-in problem gives an error for a valid Manifest
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 11:59 EDT by Zina Mostafia CLA
Modified: 2010-05-10 22:19 EDT (History)
4 users (show)

See Also:
curtis.windatt.public: review+
curtis.windatt.public: review? (darin.eclipse)

Attachments
patch (791 bytes, patch)
2010-05-10 16:04 EDT, Darin Wright CLA 		no flags Details | Diff
Additional Fixes (6.04 KB, patch)
2010-05-10 17:06 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zina Mostafia CLA 2010-05-10 11:59:22 EDT 
Build Identifier: 3.6

The Plug-in Manifest validator is complaining from a missing Bundle-Name header, while this header entry is optional according to the OSGi specifications.

Bundle-Name          optional Recommended human readable name of this framework.



Reproducible: Always

Steps to Reproduce:
1.Create a new Plugin
2.Open the Manifest and remove the optional entry Bundle-Name: x.y.z
3.You will get a Validation error.
Comment 1 Darin Wright CLA 2010-05-10 16:04:32 EDT 
Created attachment 167808 [details]
patch

Validation has been there since day one, but the header is not required. Simple fix to remove the check.
Comment 2 Darin Wright CLA 2010-05-10 16:04:52 EDT 
please review, Curtis.
Comment 3 Curtis Windatt CLA 2010-05-10 17:06:12 EDT 
Created attachment 167820 [details]
Additional Fixes
Comment 4 Chris Aniszczyk CLA 2010-05-10 17:08:38 EDT 
We should make sure this doesn't have any unintended repercussions... for example, if you change the preference to show bundle name's instead of IDs... do we fail?
Comment 5 Curtis Windatt CLA 2010-05-10 17:09:52 EDT 
+1 I applied the patch.  There were some outstanding issues, which I fixed in HEAD, but they are captured by the attached "additional fixes" patch.

Darin, please verify these fixes.

Fix 1: The manifest editor had additional validation in the general info section
Fix 2: The new project creation wizard had additional validation of the name header
Comment 6 Curtis Windatt CLA 2010-05-10 17:14:15 EDT 
(In reply to comment #4)
> We should make sure this doesn't have any unintended repercussions... for
> example, if you change the preference to show bundle name's instead of IDs...
> do we fail?

No, the label provider uses blank strings in that case.
Comment 7 Darin Wright CLA 2010-05-10 22:19:20 EDT 
If I remove the name of a plug-in that has been externalized (in the manifest editor), I still get a warning in the editor: "The specified value is not externalized".