Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312278 - [performance] Opening the LCD is slow
Summary: [performance] Opening the LCD is slow
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 309884 313388
  Show dependency tree
 
Reported: 2010-05-10 11:26 EDT by Darin Wright CLA
Modified: 2010-05-21 11:22 EDT (History)
2 users (show)

See Also:
curtis.windatt.public: review+
ankur_sharma: review+

Attachments
patch (1.54 KB, patch)
2010-05-14 14:49 EDT, Darin Wright CLA 		no flags Details | Diff
update (2.37 KB, patch)
2010-05-14 14:53 EDT, Darin Wright CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2010-05-10 11:26:50 EDT 
Opening the LCD for Eclipse applications seems slow again. I have a case where I'm using feature based launch with 400+ features, and opening the LCD takes about 15 seconds. 

Also, typing/changing the "name" field of a configuration seems slow.

Needs investigation.
Comment 1 Darin Wright CLA 2010-05-14 13:45:30 EDT 
I filed bug 312949 for the issue with typing in the name field (which is a platform bug). Typing in the Eclipse Application fields seems fine, however, opening the LCD on an Eclipse Application, and switching between them is slow.
Comment 2 Darin Wright CLA 2010-05-14 14:49:32 EDT 
Created attachment 168582 [details]
patch

Using YourKit, I found that 50% of the time switching to a feature based launch is due to the fact that the feature block creates new workspace/external feature model managers each time it is used. It's much faster to re-use the existing managers from PDE.
Comment 3 Darin Wright CLA 2010-05-14 14:53:17 EDT 
Created attachment 168583 [details]
update

Forgot to include the change in pde.core as well.
Comment 4 Curtis Windatt CLA 2010-05-18 09:43:51 EDT 
+1, waiting for Ankur's review.  Looks like he wasn't cc'd, so he may have missed the review request.
Comment 5 Ankur Sharma CLA 2010-05-18 12:00:13 EDT 
+1

We need to make these changes in BundleLauncherHelper.getMergedBundleMap also. Is there a bug for it already?
Comment 6 Curtis Windatt CLA 2010-05-18 12:25:22 EDT 
Fixed in HEAD.
Comment 7 Curtis Windatt CLA 2010-05-18 12:30:32 EDT 
I removed the fmm.shutdown() line just after where we get the feature model manager.  It only removes the listeners, but we shouldn't be doing that to the default model manager.
Comment 8 Darin Wright CLA 2010-05-21 11:22:56 EDT 
Verified.