Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312271 - [Design] Tabbar sometimes hides active editor
Summary: [Design] Tabbar sometimes hides active editor
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 10:47 EDT by Niels Lippke CLA
Modified: 2010-06-09 03:26 EDT (History)
1 user (show)

See Also:

Attachments
Screenshot that demonstrates the bug (138.90 KB, image/png)
2010-05-10 10:47 EDT, Niels Lippke CLA 		no flags Details
Fixes the problem (4.21 KB, patch)
2010-05-19 09:51 EDT, Holger Staudacher CLA 		no flags Details | Diff
new fix (5.47 KB, patch)
2010-05-19 10:15 EDT, Holger Staudacher CLA 		b.muskalla: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niels Lippke CLA 2010-05-10 10:47:04 EDT 
Created attachment 167721 [details]
Screenshot that demonstrates the bug

The overflow functionality for the tabbar in the designs' stackpresentations 
does not work, properly.
Steps to reproduce: 
Start the demo workbench with the sample designs and begin to open one 
editor after the other until the the overflow button appears. 
Subsequence new editors their tab items appears within the 
overflow list. 

This leads to open editors without corresponding active tab 
which is confusing for the user (see screenshot).
Comment 1 Holger Staudacher CLA 2010-05-19 09:51:18 EDT 
Created attachment 169112 [details]
Fixes the problem

The attached patch adds a new method which getting invoked when a view becomes active. The method makes the partButton for the active view visible and pushes it out of the overflow.
Comment 2 Holger Staudacher CLA 2010-05-19 10:15:58 EDT 
Created attachment 169116 [details]
new fix

The last fix produces a NPE when you added an unnaturally amount of viewparts and click around out of control (bennies workflow).
Comment 3 Benjamin Muskalla CLA 2010-05-19 10:34:55 EDT 
Comment on attachment 169116 [details]
new fix

Works as expected, feel free to commit.
Comment 4 Holger Staudacher CLA 2010-05-19 10:35:34 EDT 
Changes are in CVS HEAD.
Comment 5 Niels Lippke CLA 2010-06-03 07:46:00 EDT 
Sorry, this not fixed, completely. There's is still a way to get an editor without having its tab in the tabbar :

To do so programmatically activate an editor, for which its tab in the overflow menu.
Comment 6 Holger Staudacher CLA 2010-06-08 09:44:04 EDT 
Hi Niels,
I think your original described problem is solved. Please open a new bug for your programatic scenario. It would be great when you can attach a sample to reproduce the bug. I will close the bug again.
Comment 7 Niels Lippke CLA 2010-06-09 03:26:41 EDT 
Created Bug #316247