Community
Participate
Working Groups
Logical view of the Test Navigator does not show new test assets. Steps to reproduce: 1) Create a new project with a folder. 2) In the Resource view of the Test Navigator, create an artifact in the folder. 3) Open the Logical view of the Test Navigator. 4) Note, the new artifact does not appear. Refreshing does not resolve the symptom requiring a restart of Eclipse to display the artifact. Requires new tests covering all of the test assets for both views of the Test Navigator (e.g. create in the Resource view and opening the Logical view and create in the Logical view and opening the Resource view). Appears to be a regression from https://bugs.eclipse.org/bugs/show_bug.cgi?id=308891.
Jerome, please size and complete.
Created attachment 167814 [details] Screen shot showing unpainted test assets Notes on both Paul's comments and my finding: (Driver used: TPTP-4.7.0M7-201005041505) 1: I am actually unable to reproduce following Paul's steps 2: I can consistently reproduce the defect by: - Create a project, and a test asset, say: artifact "art1" in it, both done under resource view - Switch to logical view, note that "art1" shows up - Switch to resource view, create another test asset, say: artifact "art2" under the same project - Switch to logical view, note that "art2" does not show up. - Switch to resource view, notice the following exception: (Sometimes the test assets are not painted as well, see attachment) =========Exception Start========= org.eclipse.swt.SWTException: Graphic is disposed at org.eclipse.swt.SWT.error(SWT.java:4083) at org.eclipse.swt.SWT.error(SWT.java:3998) at org.eclipse.swt.SWT.error(SWT.java:3969) at org.eclipse.swt.graphics.Image.getImageData(Image.java:1209) at org.eclipse.swt.internal.ImageList.set(ImageList.java:401) at org.eclipse.swt.internal.ImageList.add(ImageList.java:66) at org.eclipse.swt.widgets.Tree.imageIndex(Tree.java:3636) at org.eclipse.swt.widgets.Tree.wmNotifyChild(Tree.java:7217) at org.eclipse.swt.widgets.Control.wmNotify(Control.java:5095) at org.eclipse.swt.widgets.Composite.wmNotify(Composite.java:1887) at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:4725) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4214) at org.eclipse.swt.widgets.Display.windowProc(Display.java:4873) at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method) at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2362) at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1536) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4250) at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:4886) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2459) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3655) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2601) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2565) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2399) at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:669) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:662) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:618) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574) at org.eclipse.equinox.launcher.Main.run(Main.java:1407) =========Exception End=========
Could https://bugs.eclipse.org/bugs/show_bug.cgi?id=274496 be related? Ran into this symptom during verification of the above.
(In reply to comment #3) > Could https://bugs.eclipse.org/bugs/show_bug.cgi?id=274496 be related? > Ran into this symptom during verification of the above. It shouldn't be reproducible since it was fixed in TPTP 4.6.1. Please reopen 274496 if it consistently reproducible.
Required to resolve failures in /org.eclipse.hyades.test.ui.navigator.tests/gui/Test.UI.TestNavigator_Logical_auto.testsuite.
(In reply to comment #2) > Created an attachment (id=167814) [details] > Screen shot showing unpainted test assets > > Notes on both Paul's comments and my finding: > > (Driver used: TPTP-4.7.0M7-201005041505) > > 1: I am actually unable to reproduce following Paul's steps > 2: I can consistently reproduce the defect by: > - Create a project, and a test asset, say: artifact "art1" in it, both done > under resource view > - Switch to logical view, note that "art1" shows up > - Switch to resource view, create another test asset, say: artifact "art2" > under the same project > - Switch to logical view, note that "art2" does not show up. > - Switch to resource view, notice the following exception: > (Sometimes the test assets are not painted as well, see attachment) ok, i am able to reproduce it i do not see the exception you attached, even if i open editor on it before switching view working on it
ok, after some investigations, it seems that the newly created element does not have the good "TestAssetGroupProxyNode" as parent it seems to be a problem inside the resource listener.
ok, a bit closer on the problem : problem lies inside TestAssetGroupProxyManager, in "visit" method at the same time, there is a resource change and a marker change on a same resource the filter see that marker change is not a graphical one and then, directly exit without looking at the resource change itself, making the logical viewer to not be updated
Created attachment 168956 [details] patch this patch fix the "filter" problem on resource listener for logical view if files are added or removed, the logical view is now updated this bug was a regression from fix for 307969 (we not only filtered changes on not graphic markets, but also the adding/removing of resource which was not expected)
Paul, could you review this patch please ? i'll add a test case tomorrow many thanks in advance
(In reply to comment #10) > Paul, could you review this patch please ? i'll add a test case tomorrow > > many thanks in advance Reviewed and approved. Please deliver to CVS (HEAD). Note, now that /org.eclipse.hyades.test.ui.navigator.tests/gui/Test.UI.TestNavigator_Logical_auto.testsuite has been fixed under https://bugs.eclipse.org/bugs/show_bug.cgi?id=294741, it covers creating/displaying all of the test assets in the Logical view. Please create a new manual test suite (added to CVS and the WIKI) for creating all of the test assets in the Resource view and changing to the Logical view to verify their display.
The attached patch checked in to CVS (HEAD) so we can start a build to verify using the /org.eclipse.hyades.test.ui.navigator.tests/gui/Test.UI.TestNavigator_Logical_auto.testsuite AGR test suite.
test suite added under CVS wiki updated updating status to fixed
Verified in TPTP-4.7.0-201005190801. Closing.
