Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312229 - [expression view][delta] Missing delta for expressions
Summary: [expression view][delta] Missing delta for expressions
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 6.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 05:49 EDT by Marc Khouzam CLA
Modified: 2010-07-28 15:26 EDT (History)
2 users (show)

See Also:
pawel.1.piech: review+
ed.swartz: review+

Attachments
Fix (2.39 KB, patch)
2010-05-10 05:49 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2010-05-10 05:49:00 EDT 
Created attachment 167674 [details]
Fix

I noticed that the new "cast to type" dsf feature would do a full view refresh() whenever an expression was casted.  This seemed excessive, but removing it prevented to the view from showing the change.

I tracked it down to a missing delta in VariableVMNode.

This patch fixes the missing delta and removes the refresh() call.
Comment 1 Marc Khouzam CLA 2010-05-10 05:50:25 EDT 
Pawel, can you ok this fix before I commit?
Comment 2 Marc Khouzam CLA 2010-05-10 05:51:09 EDT 
Ed, can you confirm that removing the call to refresh() is ok?
Comment 3 Ed Swartz CLA 2010-05-10 08:12:47 EDT 
Works for me in EDC.
Comment 4 Pawel Piech CLA 2010-05-10 16:12:38 EDT 
Yes, this makes sense.  Thanks Marc.
Comment 5 Marc Khouzam CLA 2010-05-10 16:16:20 EDT 
Committed to HEAD.