Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312217 - Restore CompareRevisionAction#findReusableCompareEditor(CompareEditorInput , IWorkbenchPage)
Summary: Restore CompareRevisionAction#findReusableCompareEditor(CompareEditorInput , ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 304019 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-10 04:32 EDT by Szymon Brandys CLA
Modified: 2010-05-12 04:35 EDT (History)
1 user (show)

See Also:
tomasz.zarna: review+

Attachments
Fix v01 (5.22 KB, patch)
2010-05-10 05:27 EDT, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2010-05-10 04:32:27 EDT 
CompareRevisionAction#findReusableCompareEditor(CompareEditorInput , IWorkbenchPage) is used in a product.
Comment 1 Szymon Brandys CLA 2010-05-10 05:27:08 EDT 
Created attachment 167671 [details]
Fix v01
Comment 2 Szymon Brandys CLA 2010-05-10 05:28:52 EDT 
The patch also adds a DoNotRemove test for org.eclipse.team.internal.ui.Utils#updateLabels(org.eclipse.team.core.synchronize.SyncInfo, org.eclipse.compare.CompareConfiguration).
Comment 3 Tomasz Zarna CLA 2010-05-10 06:03:58 EDT 
Looks good to me, assertion failed comments are fixed in HEAD.
Comment 4 Szymon Brandys CLA 2010-05-10 06:04:33 EDT 
The fix is in HEAD.
Comment 5 Szymon Brandys CLA 2010-05-12 04:35:08 EDT 
*** Bug 304019 has been marked as a duplicate of this bug. ***