Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312199 - [metadata] Match expression of update descriptor not persisted as such
Summary: [metadata] Match expression of update descriptor not persisted as such
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Thomas Hallgren CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 311269
  Show dependency tree
 
Reported: 2010-05-09 22:03 EDT by Pascal Rapicault CLA
Modified: 2010-05-11 14:57 EDT (History)
0 users

See Also:
pascal: review+

Attachments
Partial patch (6.13 KB, patch)
2010-05-09 22:08 EDT, Pascal Rapicault CLA 		no flags Details | Diff
Patch with reader side implemented (10.24 KB, patch)
2010-05-11 03:16 EDT, Thomas Hallgren CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2010-05-09 22:03:34 EDT 
Persisting match expressions from the update descriptors fail if the match is not a RequiredCapability.
Comment 1 Pascal Rapicault CLA 2010-05-09 22:08:23 EDT 
Created attachment 167646 [details]
Partial patch

Thomas, here is a test showing the problem and a partial patch dealing with the writing aspect of things. Could you please take care of the reading part of this? Thx.
Comment 2 Thomas Hallgren CLA 2010-05-11 02:43:04 EDT 
Your patch suggests that the severity and description are discarded unless a simple requirement is used. I would have thought that the requirement only replaces the name and range and that the severity and description should be serialized regardless. Can you please explain?
Comment 3 Thomas Hallgren CLA 2010-05-11 03:16:39 EDT 
Created attachment 167868 [details]
Patch with reader side implemented

This patch does the following:

1. changes the behavior from the previous patch so that the writer
    side so that the description and severity is serialized always.
2. Implements the reader site.
3. Fixed the names of the affected IU's in the test.

The test is now green.
Comment 4 Pascal Rapicault CLA 2010-05-11 14:57:30 EDT 
Patch released.