Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312190 - Creating Connector 1.6 project with DD generates two <diplay-name> tags, one of the empty.
Summary: Creating Connector 1.6 project with DD generates two <diplay-name> tags, one ...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Hari Shankar CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-09 16:17 EDT by Hari Shankar CLA
Modified: 2010-05-13 23:13 EDT (History)
3 users (show)

See Also:
hshanka: pmc_approved? (david_williams)
hshanka: pmc_approved? (raghunathan.srinivasan)
hshanka: pmc_approved? (naci.dai)
hshanka: pmc_approved? (deboer)
neil.hauge: pmc_approved+
hshanka: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
patch (1.10 KB, patch)
2010-05-09 16:18 EDT, Hari Shankar CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hari Shankar CLA 2010-05-09 16:17:24 EDT 
Build Identifier: 32

Create a Connector 1.6 project with DD. The DD includes the <display-name> tag twice. The first tag is empty.

Reproducible: Always
Comment 1 Hari Shankar CLA 2010-05-09 16:18:18 EDT 
Created attachment 167633 [details]
patch

This patch removes the display name tag from the template file, since it is being added with the correct value in the install delegate.
Comment 2 Chuck Bridgham CLA 2010-05-10 14:49:12 EDT 
approved
Comment 3 Hari Shankar CLA 2010-05-12 12:11:39 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
The issue here is that an unwanted/invalid xml content is generated. This causes display issues in the navigator model node.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 
Workaround is to manually edit the deployment descriptor to remove the additional display-name tag. This may not be a good interim solution because it requires the users to edit the xml and fix issues in the tooling generated contents.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Tested creating a connector project with DD on windows and ensured that only one display-name tag is added.

    * Give a brief technical overview. Who has reviewed this fix? 
This fix has been reviewed by Chuck Bridgham.
    * What is the risk associated with this fix? 
There are no known risks associated with the fix.
Comment 4 Jason Sholl CLA 2010-05-12 15:28:49 EDT 
code checked into head for WTP 3.2 RC1