Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312189 - [quick assist] BadLocationException when applying proposal while preview is computed
Summary: [quick assist] BadLocationException when applying proposal while preview is c...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 293995
Blocks: 195834
  Show dependency tree
 
Reported: 2010-05-09 15:58 EDT by Markus Keller CLA
Modified: 2010-12-16 05:02 EST (History)
2 users (show)

See Also:

Attachments
Fix 1 (2.96 KB, patch)
2010-05-09 16:02 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-05-09 15:58:16 EDT 
I20100504-0800

Follow-up to bug 293995 and bug 195834.

The workaround for the deadlock from bug 293995 comment 9 made bug 195834 reappear on GTK.
Comment 1 Markus Keller CLA 2010-05-09 16:02:04 EDT 
Created attachment 167632 [details]
Fix 1

Potential fix that implements the synchronization with a barrier and polling (to prevent the deadlock that occurs with a Java 'synchronized' monitor).
Comment 2 Markus Keller CLA 2010-05-09 16:08:41 EDT 
The patch is not trivial to understand and has not been tested intensively. We will probably live with the BadLocationException in 3.6 on GTK and only fix this in 3.7 (and 3.6.1, if successful).
Comment 3 Markus Keller CLA 2010-08-18 11:10:14 EDT 
Committed the patch to HEAD.
Comment 4 Dani Megert CLA 2010-12-06 09:17:39 EST 
I've released the fix into R3_6_maintenance.
Comment 5 Deepak Azad CLA 2010-12-07 10:56:33 EST 
Verified on Linux-GTK with M20101201-0800.
Comment 6 Dani Megert CLA 2010-12-16 05:02:56 EST 
(In reply to comment #5)
> Verified on Linux-GTK with M20101201-0800.
The fix got released on December 6. It looks like your verification steps are not too good. ;-)

Verified in the code that the fix is in M20101215-0800. Deepak, please verify it again using M20101215-0800.