Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312183 - Unstable tokens file
Summary: Unstable tokens file
Status: CLOSED WORKSFORME
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-09 10:32 EDT by Ed Willink CLA
Modified: 2010-05-09 14:20 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2010-05-09 10:32:03 EDT
The lines in the *.tokens file appear to be in random, probably accidental hash, order.

Please apply an alphabetic or numeric sort so that after regeneration there is not a difference to reconcile with CVS.
Comment 1 Sebastian Zarnekow CLA 2010-05-09 13:24:39 EDT
The order is neither arbitrary nor random but depends only on the order of rules / keywords in your grammar. We haven't had any issues with these files in any of our 130 testlanguages or in our production languages.

Do you get any Antlr warnings or errors when you regenerate your language?
Comment 2 Ed Willink CLA 2010-05-09 14:00:47 EDT
Checking the CVS history, it's mostly stable as you say.

The M6 development shows gentle change.

The regeneration under M7 shows a massive change.

Subsequent regeneration under M7 shows another massive change, back to the M6 evolution.

The transition to M7 was so painful, that I guess something difficult to reproduce happened. Close as CANT REPRODUCE and I'll reopen if another disproportionate change happens.

?? Could be because i deleted src-gen in an attempt to get rid of MWE2 stack traces ??

No I don't see any ANTLr errors or warnings (in the console).

Under M7 the compiler warnings are _much_ better; just need to sort out NLS and @Override.
Comment 3 Sebastian Zarnekow CLA 2010-05-09 14:20:48 EDT
The contents of src-gen is erased anyway before anything is regenerated so I guess that has nothing to do with the intermediate instable *.tokens file. If you can track this one down to something which can be reproduces, please feel free to open a ticket.

Meanwhile, the warnings have been reduced to zero for the src-gen folder.