Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312175 - Repository references enabled although flag says disabled.
Summary: Repository references enabled although flag says disabled.
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 312149
  Show dependency tree
 
Reported: 2010-05-09 05:00 EDT by Thomas Hallgren CLA
Modified: 2010-05-09 10:59 EDT (History)
3 users (show)

See Also:
pascal: review? (pascal)
susan: review+

Attachments
Patch that fixes the condition (1.29 KB, patch)
2010-05-09 05:04 EDT, Thomas Hallgren CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2010-05-09 05:00:34 EDT 
The ProvisioningContext method isEnabled(IRepositoryManager manager, IRepositoryReference reference) will always consider the referenced repository enabled regardless of its status.

The test is for (status | 1) == 1 and that will always yield true.
Comment 1 Thomas Hallgren CLA 2010-05-09 05:04:43 EDT 
Created attachment 167619 [details]
Patch that fixes the condition

This patch changes the test to (status & 1) == 1 instead of (status | 1) == 1
Comment 2 Pascal Rapicault CLA 2010-05-09 09:32:18 EDT 
Susan, I have reviewed and released, but I would appreciate if you could give an second look at this.
Comment 3 Susan McCourt CLA 2010-05-09 10:59:57 EDT 
yikes.  Thanks for catching that.