Comment 1 Andrew Gvozdev 2011-03-02 16:59:11 EST

*** Bug 338740 has been marked as a duplicate of this bug. ***

Comment 2 Andrew Gvozdev 2011-03-02 17:00:46 EST

As pointed out in bug 338740, sorting should be optional and use preference introduced in bug 311880.

Comment 3 Andrew Gvozdev 2012-01-09 00:02:13 EST

Fixed on master and cdt_8_0. I kept the logic of decorating the same as for files. There is some irregularity in marking which I reported in bug 368115.

Comment 4 Marc-André Laperle 2012-02-04 01:17:10 EST

Hi Andrew, I made a Hello world C++ project and tried to exclude the src source folder. The source folder icon went away but the it was not decorated as being excluded. Then I tried to exclude it again, it allowed me and it was decorated properly. But when I included it again, it was not a source folder anymore.

I then tried a second Hello world project, with two source folders, src and src2. I excluded the src folder, same thing: no decoration and now a regular folder. Then I tried to exclude it again but it didn't allow me. Then I excluded src2, similarly, it became a regular folder and not decorated. Then I could exclude both again and see the proper decoration. After including both again, they were not source folders.

Shouldn't the decoration appear the first time on a source folder? And go back to being a source folder when it's included again? I'm a bit confused on what it should do.

Comment 5 Andrew Gvozdev 2012-02-04 07:29:45 EST

You mention 2 separate issues, one is what is effect of "exclude" operation on the project model and another one what "excluded" decoration indicates.

The implemented logic of excluded decoration - which, I admit, is not ideal - is to mark excluded files and folders under source folders only. I tried decorating non-source folders but found that it was too noisy visually and frankly unacceptable for our in-house projects. We need to define it in more consistent and user-friendly way and I suggest to discuss it further in bug 368115.

Comment 6 CDT Genie 2012-02-29 13:20:57 EST

*** cdt git genie on behalf of Andrew Gvozdev ***

    bug 312165: Viewers should clearly indicate whether a folder is excluded
    from build
    Conflicts:
    	core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/viewsupport/ExcludedFileDecorator.java

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=e62f6b43d8b36679705c14f2c78cc400fa2f30fa

Comment 7 CDT Genie 2012-02-29 13:21:00 EST

*** cdt git genie on behalf of Andrew Gvozdev ***

    bug 312165: Viewers should clearly indicate whether a folder is excluded
    from build

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=a98cf9a89dd9ee378dfe2a716450774b245816af

Comment 8 CDT Genie 2012-02-29 13:21:01 EST

*** cdt git genie on behalf of Andrew Gvozdev ***

    bug 312165: Viewers should clearly indicate whether a folder is excluded
    from build

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=76d3d7f2e62fb3f9560279388069e0b8203a314b