Community
Participate
Working Groups
Add a 'Show only selected' check box filter on feature based configs. It should behave similar to the one on the plug-ins tab of a plug-ins based config.
Created attachment 167600 [details] Patch
This plays well, but to make it better we should... * Add a "Select Features..." button, that allows the user to select features from a dialog (like the 'add plug-in' dialog). This allows the user to add features to an empty list. The dialog should filter features that are already selected in the tab * To avoid flash/flicker when updating the tree, setRedraw(false/true) should be used when updating (for example when pressing "Show selected only", or when adding plug-in, etc).
I've also noticed a bug with text filtering corrupting the selection state: * with "only show selected" on, add a plug-in to the launch * plug-in appears * type some text in the filter to make the plug-in filtered * clear the filter text Bug: the plug-in does not re-appear, and when I un-check "only show selected", the plug-in is no longer selected.
(In reply to comment #3) > I've also noticed a bug with text filtering corrupting the selection state: > > * with "only show selected" on, add a plug-in to the launch > * plug-in appears > * type some text in the filter to make the plug-in filtered > * clear the filter text > > Bug: the plug-in does not re-appear, and when I un-check "only show selected", > the plug-in is no longer selected. This probably happens anytime there are overlapping viewer filters. When one filter is removed, we use the cache to check the right items, but the item is still filtered. When we remove the second filter, not all of the items are checked. The same problem existed in the target content tab, I'll have to look at the fix we put in there.
Created attachment 167877 [details] Patch This does not include fix for the multiple viewer filter problem mentioned in comment 3 and 4
The following steps do not work for me: * Open a new config to the plug-ins tab using feature launch mode * De-select all * check "only show selected" * Press "Select Features..." and choose org.eclipse.pde Nothing appears in the tree, although the selection count shows '1 of 16' * press "Select Required" Nothing gets added, and selection count remains the same (Note, "Select required" should have a capital 'R' on Required) ("Select features" should use a capital 'F' as well).
Created attachment 167960 [details] Updated patch
Created attachment 168040 [details] Updated Patch II Catches up to HEAD, fixes button ordering/naming/mnemonics, fixes the filtering issue from earlier comments. There are still two minor issues that may not be worth fixing for RC1. On linux, there isn't enough space in the default launch dialog to fit all of the buttons/options in the right column so the x of y selected label gets cut off. Second, changing the 'selected only' option changes the attribute for both plug-in block and feature block, but if the option is switched in one block, it is not updated in the other.
I'm happy with the fix, but I updated the code enough that it needs another reviewer. Darin, please review/apply the latest patch.
Applied/Fixed. I found one update issue, but I'll file a separate bug for it.
