Community
Participate
Working Groups
Created attachment 167553 [details] proposed patch If a shape compartment is selected that has ContainerEditPolicy installed on it then the "Arrange Selection" action is enabled, while it should be disabled as in GMF 2.2 The problem is that AarrangeCommand shouldn't have the container editpart contents of which are to be arranged in the list of nodes to be laid out. This is currently possible. Given that ContainerEditPolicy is installed on all shapes instead of just the container shapes e.g diagrams and shape compartments the fix would be: 1) Ensure that arrange command doesn't add the container editpart to the list of nodes to be laid out 2) Provide the support in ContainerEditPolicy and ShapeContainerEditPolicy to return the correct target editpart, namely the container editpart for the arrange request. Tested the patch manually as well as ran JUnits. Romain buddy tested the fix as well. Seems to work ok. Anthony, can you please code review this fix? Thanks in advance!
Hi Lidija, Can you please code review this patch? Thanks!
Hi Alex, the patch is invalid /cvsroot/modeling/org.eclipse.gmf/plugins/ does not exist anymore, the code is in /cvsroot/modeling/org.eclipse.gmp/org.eclipse.gmf.runtime/plugins/
Alex, I checked out the patch in my old workspace, changes seem good. I assume you will remove System.out.println from ArrangeCommand and create a valid patch (in new workspace).
:-) right, I did reove it, just keep forgetting that the uploaded patch still has it.
Delivered for 2.3
[target cleanup] 2.3 RC was the original target milestone for this bug
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug
