Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312113 - Rhino debugger's prototype and protoObect are wrong
Summary: Rhino debugger's prototype and protoObect are wrong
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Simon Kaegi CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 14:49 EDT by Simon Kaegi CLA
Modified: 2010-05-12 17:39 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+

Attachments
proposed patch (2.95 KB, patch)
2010-05-07 15:29 EDT, Simon Kaegi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2010-05-07 14:49:41 EDT 
The "protoObject" should just be the Scriptable returned from Scriptable.getProtoType(). 

The "prototype" is just a property that should generally only be on constructor functions.
Comment 1 Simon Kaegi CLA 2010-05-07 15:29:19 EDT 
Created attachment 167549 [details]
proposed patch

The protoObject is redundant. We just use the prototypeObject for the underlying (and normally hidden) prototype of the Object and the regular "prototype" property is accessed as a property.
Comment 2 Michael Rennie CLA 2010-05-07 15:32:45 EDT 
+1 super-fantastic!
Comment 3 Simon Kaegi CLA 2010-05-09 23:12:04 EDT 
.