Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312107 - [Help] Criteria inheritance requirement can be confusing
Summary: [Help] Criteria inheritance requirement can be confusing
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 14:34 EDT by Chris Austin CLA
Modified: 2011-04-15 11:12 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Austin CLA 2010-05-07 14:34:29 EDT
This is just a bug to get some feedback / open a discussion on the inheritance requirement for criteria.  Currently, in order to filter and see a topic with a criteria value applied, that same value must be applied to all of its parent topics.  Because of this, it can be easy to add criteria to a subtopic and forget to add it to all parents.  Also, if you have a large tree of parents, it can become involved to add new criteria to all levels.
Comment 1 Chris Goldthorpe CLA 2010-05-07 14:47:54 EDT
Vivian, I would be interested to know if other users have seen this also. We made this decision several milestones back for reasons of performance and algorithm complexity and we certainly would not change this for 3.6. Have you heard of other users not realizing that all ancestors need to also contain each criterion in their descendants.
Comment 2 Hao Zhang CLA 2010-05-07 22:22:41 EDT
Chris, all the existed criteria doc follow this rule. I think user has already realized that.

If we rely on the program to do such issue, I think it will cause performance issue.

What's your opinion?
Comment 3 Chris Goldthorpe CLA 2010-05-11 14:09:50 EDT
My opinion is that we should not change the algorithm for Eclipse 3.6 since we went through a design review and decided that for reasons of performance and code complexity we would require that for an element to show in the table of contents the element and all ancestors must satisfy the criteria constraints. 

On the other hand users are likely to make the mistake of not setting the criteria for all ancestors, I have done this myself. I suppose that we could issue a warning in the log if a situation is encountered where a child has criteria that it's parent does not have. If we were still in milestone 7 I would support that change but now we are building release candidates my inclination is that we only fix the most serious problems.

We can revisit this for the next release and decide whether we want to support non hierarchical criteria.
Comment 4 Hao Zhang CLA 2010-05-11 21:19:13 EDT
I agree with you.

Maybe we can find a better solution.
Comment 5 Chris Austin CLA 2010-12-16 09:27:16 EST
Any thoughts on a final solution for this bug?
Comment 6 Chris Austin CLA 2011-04-15 11:12:27 EDT
I think interest in changing this feature right now is pretty low - closing this out for now.  If there is more discussion, feel free to reopen.