Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312077 - MToolControls aren't rendered on MacOS X
Summary: MToolControls aren't rendered on MacOS X
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 10:46 EDT by Brian de Alwis CLA
Modified: 2010-06-04 16:29 EDT (History)
0 users

See Also:

Attachments
Implementation of a ToolControlRenderer (5.69 KB, patch)
2010-05-07 10:47 EDT, Brian de Alwis CLA 		no flags Details | Diff
Wrap tool controls within a ToolItem (1.95 KB, patch)
2010-05-17 13:02 EDT, Brian de Alwis CLA 		no flags Details | Diff
Reworked patch to support embedding in both ToolBar and Composite (1.85 KB, patch)
2010-05-17 13:15 EDT, Brian de Alwis CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2010-05-07 10:46:38 EDT 
Build: HEAD 2010/05/05 @ 7am

I was trying out to add a MToolControl to discover that WorkbenchRendererFactory is missing a tool control renderer.  Implementation to follow.
Comment 1 Brian de Alwis CLA 2010-05-07 10:47:38 EDT 
Created attachment 167487 [details]
Implementation of a ToolControlRenderer
Comment 2 Brian de Alwis CLA 2010-05-17 13:02:09 EDT 
Created attachment 168765 [details]
Wrap tool controls within a ToolItem

Follow approach defined in SWT Snippet 58 and embed the widget inside a ToolItem marked as an SWT.SEPARATOR. (http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet58.java)
Comment 3 Brian de Alwis CLA 2010-05-17 13:03:15 EDT 
Eric independently added a MToolControl renderer, but his implementation unfortunately doesn't work under MacOS X.  So I'll repurpose this bug to address the issue.
Comment 4 Brian de Alwis CLA 2010-05-17 13:15:48 EDT 
Created attachment 168767 [details]
Reworked patch to support embedding in both ToolBar and Composite
Comment 5 Eric Moffatt CLA 2010-05-25 14:22:06 EDT 
Committed in >20100525. Applied Brian's patch.