Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312075 - [ValueConverter] Use the lexer to identify valid values
Summary: [ValueConverter] Use the lexer to identify valid values
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 10:45 EDT by Sebastian Zarnekow CLA
Modified: 2017-09-19 15:53 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: helios+

Attachments
Patch without regenerated noise (21.19 KB, patch)
2010-05-07 10:48 EDT, Sebastian Zarnekow CLA 		no flags Details | Diff
Patch with regnerated code (152.92 KB, patch)
2010-05-07 10:49 EDT, Sebastian Zarnekow CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2010-05-07 10:45:42 EDT 

    


    


      



        
          Comment 1
        

        
          Sebastian Zarnekow CLA

        

        
        

        
          2010-05-07 10:48:20 EDT
        

      






Created attachment 167488 [details]
Patch without regenerated noise

The patch does not change contain breaking changes in the generated. However, there was some noise after a complete regeneration that's why I attach two patches.

    


    


      



        
          Comment 2
        

        
          Sebastian Zarnekow CLA

        

        
        

        
          2010-05-07 10:49:13 EDT
        

      






Created attachment 167489 [details]
Patch with regnerated code

    


    


      



        
          Comment 3
        

        
          Sven Efftinge CLA

        

        
        

        
          2010-05-07 10:56:21 EDT
        

      






looks good

    


    


      



        
          Comment 4
        

        
          Sebastian Zarnekow CLA

        

        
        

        
          2010-05-07 11:00:21 EDT
        

      






Thanks for the review.

Moritz suggested to that assertNotNull() is a bad name so I'll rename it to assertValidValue() and commit the patch.

    


    


      



        
          Comment 5
        

        
          Sebastian Zarnekow CLA

        

        
        

        
          2010-05-07 11:22:54 EDT
        

      






Fixed in HEAD.

    


    


      



        
          Comment 6
        

        
          Karsten Thoms CLA

        

        
        

        
          2017-09-19 15:53:09 EDT
        

      






Closing bug which were set to RESOLVED before Eclipse Neon.0.