Community
Participate
Working Groups
Reproducible: Always Steps to Reproduce: * In the Java perspective, right click a Java project, goto Build Path > Link Source... * Select Variables... Notice that none of the project path variables are listed (to see the project path variable list, see the property page "Resource / Linked Resources"). This is done by adding in 'AddSourceFolderWizardPage.java" line 171: PathVariableSelectionDialog dialog = new PathVariableSelectionDialog(getShell(), variableTypes); dialog.setResource(fParent); Note that internally, the resolution of that Path (if done manually) must call IResource.getPathVariableManager() instead of IWorkspace.getPathVariableManager().
Deepak, can you check how much work this would be and whether it makes sense that clients have to fill in/resolve that information?
Deepak, if you don't see what's going on then please reassign to me. Most likely we'll defer this to 3.7.
Created attachment 168907 [details] fix Fix as per Serge's suggestions.
+1 for RC2. To reduce code duplication I would assign fNewElement.getJavaProject().getProject() to a local variable (same code already used a few lines above). Please attach a new patch and ask Raksha for review. There's also a second reference to IPathVariableManager.resolvePath(IPath) but that code is no longer used (filed bug 313339 to remove this for 3.7).
That looks great. thanks
Created attachment 168938 [details] reworked patch
Patch is good.
Patch released to HEAD.
Dani, I have a question : Why do we allow to create a new Variable using a Variable location recursively? I could do this operation * In the Java perspective, right click a Java project, goto Build Path > Link Source... * Select Variables... (Lets say you already have a variable 'x') * Create a new variable using New... button * Say 'y', use 'Variables...' to select location * Remove... 'x', select some other variable location , OK => In the old dialog , you can still see the removed variable in the list That variable is never removed from the list even after you finish all the dialogs. Should we allow 'New/Edit/Remove' operations recursively at all or should we only allow it once and then use another dialog to show only the list for selection?
(In reply to comment #9) > Dani, I have a question : Why do we allow to create a new Variable using a > Variable location recursively? I could do this operation > > * In the Java perspective, right click a Java project, goto Build Path > Link > Source... > * Select Variables... (Lets say you already have a variable 'x') > * Create a new variable using New... button > * Say 'y', use 'Variables...' to select location > * Remove... 'x', select some other variable location , OK > => In the old dialog , you can still see the removed variable in the list > That variable is never removed from the list even after you finish all the > dialogs. > > Should we allow 'New/Edit/Remove' operations recursively at all or should we > only allow it once and then use another dialog to show only the list for > selection? This dialog is a standard ui.ide dialog, not a JDT specific one, and there's an open bug tracking this issue: Bug 312084
(In reply to comment #10) > (In reply to comment #9) > This dialog is a standard ui.ide dialog, not a JDT specific one, and there's an > open bug tracking this issue: Bug 312084 Okay, I have added my comment there. Thanks!
Verified in N20100519-2000.
