Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312071 - When disconnecting the client should cleanup before disposing of the VM
Summary: When disconnecting the client should cleanup before disposing of the VM
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Simon Kaegi CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 10:35 EDT by Simon Kaegi CLA
Modified: 2010-05-07 11:30 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+


Attachments
proposed patch (884 bytes, patch)
2010-05-07 10:43 EDT, Simon Kaegi CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2010-05-07 10:35:53 EDT
I ran into a situation where when disconnecting the client from the debugger we were getting a bunch of disconnected exceptions. We need to call cleanup which will remove requests from the vm before disposing of the vm.
Comment 1 Simon Kaegi CLA 2010-05-07 10:43:20 EDT
Created attachment 167484 [details]
proposed patch
Comment 2 Michael Rennie CLA 2010-05-07 11:27:38 EDT
+1 fix looks good for RC1
Comment 3 Michael Rennie CLA 2010-05-07 11:29:21 EDT
applied patch to HEAD