Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311963 - [Mac] [Commands] Command from 'org.eclipse.ui.cocoa' fragment references category defined in 'org.eclipse.ui.cheatsheets'
Summary: [Mac] [Commands] Command from 'org.eclipse.ui.cocoa' fragment references cate...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal with 1 vote (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Prakash Rangaraj CLA
QA Contact: Prakash Rangaraj CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 322887
  Show dependency tree
 
Reported: 2010-05-06 15:37 EDT by Christian Kesselheim CLA
Modified: 2010-09-27 04:17 EDT (History)
3 users (show)

See Also:

Attachments
Patch v01 (1.36 KB, patch)
2010-05-10 02:27 EDT, Prakash Rangaraj CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Kesselheim CLA 2010-05-06 15:37:29 EDT 
Build Identifier: I20100429-1549

It seems that there's a category reference coming from the cocoa fragment for org.eclipse.ui which pointing to a category defined in org.eclipse.ui.cheatsheets:

http://dev.eclipse.org/viewsvn/index.cgi/org.eclipse.ui.cocoa/fragment.xml?view=markup

As a result, simply creating a new RCP application by means of e.g. the "Hello RCP" template and then hitting start without further ado results in a unnecessary warning message being dumped to the user's console:

!ENTRY org.eclipse.ui 2 0 2010-05-06 21:23:30.561
!MESSAGE Warnings while parsing the commands from the 'org.eclipse.ui.commands' and 'org.eclipse.ui.actionDefinitions' extension points.
!SUBENTRY 1 org.eclipse.ui 2 0 2010-05-06 21:23:30.562
!MESSAGE Commands should really have a category: plug-in='org.eclipse.ui', id='org.eclipse.ui.cocoa.closeDialog', categoryId='org.eclipse.ui.category.dialogs'

One would think that the org.eclipse.ui.category.dialogs category should either belong to org.eclipse.ui instead of org.eclipse.ui.cheatsheets or the cocoa shouldn't reference this category after all.

Reproducible: Always

Steps to Reproduce:
1. Create an empty RCP application on MacOSX Cocoa
2. Start with minimal plug-ins (that is, no org.eclipse.ui.cheatsheets)
Comment 1 Prakash Rangaraj CLA 2010-05-10 02:27:26 EDT 
Created attachment 167660 [details]
Patch v01
Comment 2 Adriaan Peeters CLA 2010-05-25 04:22:17 EDT 
Can this fix be considered for 3.6 or 3.6.1?
Comment 3 Prakash Rangaraj CLA 2010-05-25 04:26:11 EDT 
(In reply to comment #2)
> Can this fix be considered for 3.6 or 3.6.1?

Yes, when we fix it for 3.7, we will backport to 3.6.1
Comment 4 Adriaan Peeters CLA 2010-05-27 10:46:14 EDT 
The org.eclipse.ui.carbon fragment looks identical, so it is also affected.
Comment 5 Prakash Rangaraj CLA 2010-05-27 12:57:32 EDT 
(In reply to comment #4)
> The org.eclipse.ui.carbon fragment looks identical, so it is also affected.

Right the patch in comment #1 addresses carbon as well
Comment 6 Prakash Rangaraj CLA 2010-07-30 00:27:37 EDT 
Patch v01 released to HEAD
Comment 7 Remy Suen CLA 2010-08-16 17:21:49 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Can this fix be considered for 3.6 or 3.6.1?
> 
> Yes, when we fix it for 3.7, we will backport to 3.6.1

Prakash, are you still considering this bug for the 3.6.x maintenance stream or will you not be backporting the fix?
Comment 8 Adriaan Peeters CLA 2010-09-27 03:54:58 EDT 
I can confirm it is fixed in 3.6.1.
Comment 9 Prakash Rangaraj CLA 2010-09-27 04:17:44 EDT 
(In reply to comment #8)
> I can confirm it is fixed in 3.6.1.

    Thanks Adriaan. 3.6 maintenance stream is tracked in Bug# 322887