Community
Participate
Working Groups
Build Identifier: WTP 3.2 The JavaClassImpl.getMethodElementSignatures() method is currently returning an extra signature for each method name that has more than one method defined with the same method name. For example, if the class contains methods 'method()' and 'method(long)' then the values returned are 'method', 'method()' and 'method(long)'. Reproducible: Always
Created attachment 167349 [details] Patch Patch fixes JavaClassImpl.getMethodElementSignatures() method so that the extra element is no longer added.
approved
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. The JavaClassImpl.getMethodElementSignatures() method is returning an incorrect List of method signatures since it contains additional values. This function is used by an adopter and should be fixed to work correctly. * Is there a work-around? If so, why do you believe the work-around is insufficient? No * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Tested method on different scenarios and classes. * Give a brief technical overview. Who has reviewed this fix? The getMethodElementSignatures() method is currently returning an extra signature for each method name that has more than one method defined with the same method name (see comment 1 for an example). Chuck, and Jason have reviewed this patch. * What is the risk associated with this fix? I believe the risk is minimal since it modifies a single get method.
I'm ok with this one, but in future, please better explain impact to user. I have a hard time telling from the description if a function "breaks" ... user can't do what they meant to ... or if it just looks confusing. In the weeks to come, that distinction will make a difference. Thanks,
code checked into head for 32 RC1
