Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311934 - wst.server.ui uses the Trace class from wst.server.core
Summary: wst.server.ui uses the Trace class from wst.server.core
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 13:00 EDT by Troy Bishop CLA
Modified: 2017-10-11 16:33 EDT (History)
0 users

See Also:
arvera: pmc_approved? (david_williams)
arvera: pmc_approved? (raghunathan.srinivasan)
arvera: pmc_approved? (naci.dai)
deboer: pmc_approved+
arvera: pmc_approved? (neil.hauge)
arvera: pmc_approved? (kaloyan)

Attachments
patch for WTP 3.2 (5.55 KB, patch)
2010-05-06 13:01 EDT, Troy Bishop CLA 		arvera: iplog+
arvera: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2010-05-06 13:00:39 EDT 
Build Identifier: 3.2

In an adopter product I was tracing a publishing problem and noticed that there were various trace strings contributed via the org.eclipse.wst.server.ui bundle being written as if they were contributed via org.eclipse.wst.server.core.  I will attach a patch that corrects this problem.

Reproducible: Always
Comment 1 Troy Bishop CLA 2010-05-06 13:01:18 EDT 
Created attachment 167343 [details]
patch for WTP 3.2
Comment 2 Troy Bishop CLA 2010-05-06 13:02:04 EDT 
(In reply to comment #1)
> Created an attachment (id=167343) [details]
> patch for WTP 3.2

I also modified the trace string for the server tooltips extension point loading slightly so it was a bit more verbose.
Comment 3 Angel Vera CLA 2010-05-06 16:59:04 EDT 
A good improvement with low risk that will help a lot in tracing problems.
Comment 4 Angel Vera CLA 2010-05-11 11:08:19 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Not a stop ship, but this will greatly improved the serviceability of the product.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 
No workaround

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Ran through the scenarios where the trace will print

* Give a brief technical overview. Who has reviewed this fix? 
The patch looks good after I reviewed it. 

* What is the risk associated with this fix? 
Low
Comment 5 Angel Vera CLA 2010-05-11 11:33:24 EDT 
Changes committed to HEAD. I revised the patch to include the correct date on the copyrights.
Comment 6 Angel Vera CLA 2010-05-11 11:48:52 EDT 
Changes released to HEAD
Comment 7 Eclipse Genie CLA 2017-10-11 16:33:07 EDT 
New Gerrit change created: https://git.eclipse.org/r/108942