Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311933 - Validate on feature based launch config does not consider application plug-in as requirement
Summary: Validate on feature based launch config does not consider application plug-in...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P2 major (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 13:00 EDT by Curtis Windatt CLA
Modified: 2010-05-11 14:55 EDT (History)
1 user (show)

See Also:
darin.eclipse: review+

Attachments
WIP (13.40 KB, patch)
2010-05-10 16:53 EDT, Curtis Windatt CLA 		no flags Details | Diff
Fix (22.26 KB, patch)
2010-05-11 12:51 EDT, Curtis Windatt CLA 		no flags Details | Diff
mylyn/context/zip (350.78 KB, application/octet-stream)
2010-05-11 12:51 EDT, Curtis Windatt CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-05-06 13:00:24 EDT 
1) Create a new Eclipse launch config
2) Go to plug-ins tab, change to features selected below
3) Deselect all
4) Check a random sdk feature such as org.eclipse.pde
5) Hit validate plug-ins
Result:
org.eclipse.sdk.ide is missing

The launch won't work either.  We should have code similar to the PluginBlock which checks the application and gets the required plug-in providing it.  This should happen on validate and launch time.

Since the code will be duplicated, it should be moved to a helper class or somewhere.  Otherwise fixes like bug 309860 won't fix everything everywhere.

Select required doesn't help at all since it only selects required features, it doesn't account for the launcher.  I'm not sure if changing this is a good idea.
Comment 1 Curtis Windatt CLA 2010-05-10 12:36:13 EDT 
The validation of the application in the plugin block is done inside PluginBlock.validateExtensions()
Comment 2 Curtis Windatt CLA 2010-05-10 15:56:53 EDT 
I'll look at this since I spent some time working on the JUnit config application validation.
Comment 3 Curtis Windatt CLA 2010-05-10 16:53:49 EDT 
Created attachment 167817 [details]
WIP
Comment 4 Curtis Windatt CLA 2010-05-11 12:51:07 EDT 
Created attachment 167969 [details]
Fix
Comment 5 Curtis Windatt CLA 2010-05-11 12:51:14 EDT 
Created attachment 167970 [details]
mylyn/context/zip
Comment 6 Curtis Windatt CLA 2010-05-11 12:55:39 EDT 
Darin, please review/apply the fix.
Comment 7 Darin Wright CLA 2010-05-11 14:55:38 EDT 
+1. Applied/Fixed.