Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311928 - IGDBJtagDevice should use generics
Summary: IGDBJtagDevice should use generics
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Elena Laskavaia CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 12:38 EDT by John Cortell CLA
Modified: 2010-05-06 14:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-05-06 12:38:25 EDT 
Nearly all the methods take a type-less Collection. The advantages of type-safe collections are beyond debate. To argue for the widespread use of typeless collections is akin to arguing for the use of Object as parameter types. We can switch the JtagDevice interface and built-in implementations to use Collection<String> with no adverse impact to clients because of how generics work under the covers.
Comment 1 Elena Laskavaia CLA 2010-05-06 13:08:10 EDT 
I think I bit you to it. I commit the update 30 min  before you submitted the bug.
Comment 2 Elena Laskavaia CLA 2010-05-06 13:11:19 EDT 
fixed
Comment 3 John Cortell CLA 2010-05-06 14:27:24 EDT 
(In reply to comment #1)
> I think I bit you to it. I commit the update 30 min  before you submitted the
> bug.

Indeed you did. The downstream weren't updated, though. I've taken care of them. Also, I updated the javadoc for the jtagdevice interface to make it clear that the implementor is supposed to populate the collection with gdb commands.