311920 – Executable feature does not include s390x and s390 for product builds

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311920 - Executable feature does not include s390x and s390 for product builds

Summary: Executable feature does not include s390x and s390 for product builds

Status:	RESOLVED FIXED

Alias:	None

Product:	Equinox
Classification:	Eclipse Project
Component:	Framework (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	3.6 RC1
Assignee:	equinox.framework-inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-05-06 12:12 EDT by Andrew Niefer
Modified:	2010-05-07 15:19 EDT (History)
CC List:	2 users (show)

See Also:

Flags:	tjwatson: review+

Attachments
patch (3.84 KB, patch) 2010-05-06 12:41 EDT, Andrew Niefer	no flags	Details \| Diff
updated for s390 (5.01 KB, patch) 2010-05-06 15:44 EDT, Andrew Niefer	no flags	Details \| Diff
updated (5.01 KB, patch) 2010-05-07 14:45 EDT, Andrew Niefer	no flags	Details \| Diff
s390 binaries (99.08 KB, application/octet-stream) 2010-05-07 14:46 EDT, Andrew Niefer	no flags	Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew Niefer

2010-05-06 12:12:10 EDT

The org.eclipse.equinox.executable feature is used for product builds.  It ships with a custom build.xml and build.properties which provide the launchers during the build.

It also contains the binary launcher executables for each platform.

Currently, the binary s390x executable is not included, as well, the target build.properties and build.xml do not contain information for s390

This means that releng builds using the executable.feature will not be able to target s390x.

Comment 1 Andrew Niefer

2010-05-06 12:12:53 EDT

See also bug 304516, bug 311242

Comment 2 Andrew Niefer

2010-05-06 12:41:28 EDT

Created attachment 167341 [details]
patch

Comment 3 Andrew Niefer

2010-05-06 15:24:52 EDT

Word from SWT is that there will be s390 as well.

Comment 4 Andrew Niefer

2010-05-06 15:44:55 EDT

Created attachment 167378 [details]
updated for s390

Comment 5 Andrew Niefer

2010-05-07 14:45:53 EDT

Created attachment 167532 [details]
updated

Comment 6 Andrew Niefer

2010-05-07 14:46:35 EDT

Created attachment 167533 [details]
s390 binaries

Comment 7 Thomas Watson

2010-05-07 15:13:37 EDT

I reviewed this patch with Andrew.  Looks good.  Need to update s390 fragment version.

Comment 8 Andrew Niefer

2010-05-07 15:19:58 EDT

I have released the patch with the addition of incrementing the org.eclipse.equinox.gtk.linux.s390 version to 1.1.0.qualifier.  Also, I updated the copyrights