Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311850 - org.eclipse.compare.structureCreators extension point definition specifies wrong interface
Summary: org.eclipse.compare.structureCreators extension point definition specifies wr...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 06:15 EDT by Carsten Pfeiffer CLA
Modified: 2010-05-18 05:44 EDT (History)
1 user (show)

See Also:
Szymon.Brandys: review+
pawel.pogorzelski1: review+

Attachments
Fix v01 (4.94 KB, patch)
2010-05-17 06:50 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (4.21 KB, application/octet-stream)
2010-05-17 06:50 EDT, Tomasz Zarna CLA 		no flags Details
Fix v02 (5.05 KB, patch)
2010-05-18 05:42 EDT, Tomasz Zarna CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Pfeiffer CLA 2010-05-06 06:15:57 EDT 
Build Identifier: M20100211-1343

As document in the extension point, the class attribute specifies an element implementing org.eclipse.compare.structuremergeviewer.IStructureCreator, but the attribute itself specifies the interface org.eclipse.compare.structuremergeviewer.IStructureComparator to be implemented.

Reproducible: Always
Comment 1 Tomasz Zarna CLA 2010-05-12 09:31:29 EDT 
Good catch!
Comment 2 Tomasz Zarna CLA 2010-05-17 06:50:29 EDT 
Created attachment 168710 [details]
Fix v01

Fixed schema, now requires org.eclipse.compare.structuremergeviewer.IStructureCreator to be implemented.
Comment 3 Tomasz Zarna CLA 2010-05-17 06:50:31 EDT 
Created attachment 168711 [details]
mylyn/context/zip
Comment 4 Szymon Brandys CLA 2010-05-17 09:20:17 EDT 
I found the same issue in the ext. point overview.
Comment 5 Tomasz Zarna CLA 2010-05-17 09:41:37 EDT 
The overview is fine: the structure creator implementing org.eclipse.compare.structuremergeviewer.IStructureCreator is expected to create
a tree of org.eclipse.compare.structuremergeviewer.IStructureComparators.
Comment 6 Szymon Brandys CLA 2010-05-17 09:43:14 EDT 
Fair enough.
Comment 7 Tomasz Zarna CLA 2010-05-18 05:42:10 EDT 
Created attachment 168883 [details]
Fix v02

Fixed copyrights.
Comment 8 Tomasz Zarna CLA 2010-05-18 05:44:04 EDT 
Released to HEAD, available in builds >=I201005180-0800.