Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311848 - return statement missing in JavaBreakpointListenerProxy#installingBreakpoint
Summary: return statement missing in JavaBreakpointListenerProxy#installingBreakpoint
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 06:01 EDT by Jürgen King CLA
Modified: 2010-05-11 13:57 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+


Attachments
patch (1.45 KB, patch)
2010-05-06 09:35 EDT, Darin Wright CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jürgen King CLA 2010-05-06 06:01:37 EDT
Build Identifier: M20090917-0800

The installBreakpoint Method in JavaBreakpointListenerProxy (a inner class of BreakpointListenerManager) is implemented this way:

public int installingBreakpoint(IJavaDebugTarget target, IJavaBreakpoint breakpoint, IJavaType type) {
   IJavaBreakpointListener delegate = getDelegate();
   if (delegate != null) {
      delegate.installingBreakpoint(target, breakpoint, type);
   }
   return IJavaBreakpointListener.DONT_CARE;
}

This way the return of the delegate is ignored. To me the correct statement would be:

return delegate.installingBreakpoint(target, breakpoint, type);

like it is in breakpointHit.

Reproducible: Always
Comment 1 Darin Wright CLA 2010-05-06 09:35:59 EDT
Created attachment 167302 [details]
patch

Yes, this is a bug.
Comment 2 Darin Wright CLA 2010-05-06 09:41:30 EDT
Pleaes review, Mike.
Comment 3 Darin Wright CLA 2010-05-11 10:53:33 EDT
Ping Mike for RC1 review.
Comment 4 Michael Rennie CLA 2010-05-11 13:57:15 EDT
+1 applied to HEAD