Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311765 - [Help] In help view criteria do not show localized names
Summary: [Help] In help view criteria do not show localized names
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 12:44 EDT by Chris Goldthorpe CLA
Modified: 2010-05-07 12:45 EDT (History)
1 user (show)

See Also:
zhhaohh: review+


Attachments
Screenshot (67.39 KB, image/png)
2010-05-05 12:45 EDT, Chris Goldthorpe CLA
no flags Details
Patch (1.53 KB, patch)
2010-05-05 13:05 EDT, Chris Goldthorpe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2010-05-05 12:44:57 EDT
I20100429-1549

Translation of criteria names and values works correctly in the help webapp but not in the help view where the id is shown instead of the localized name.
Comment 1 Chris Goldthorpe CLA 2010-05-05 12:45:38 EDT
Created attachment 167175 [details]
Screenshot
Comment 2 Chris Goldthorpe CLA 2010-05-05 13:05:36 EDT
Created attachment 167177 [details]
Patch
Comment 3 Chris Goldthorpe CLA 2010-05-05 13:06:41 EDT
Vivian can you review this patch for inclusion in RC1?
Comment 4 Hao Zhang CLA 2010-05-06 02:51:19 EDT
Chris, I've reviewed this patch. It is OK.
Comment 5 Chris Goldthorpe CLA 2010-05-06 12:42:00 EDT
I forgot to add you as a reviewer - can you set the review to '+'.
Comment 6 Hao Zhang CLA 2010-05-06 21:09:39 EDT
Done.
Comment 7 Chris Goldthorpe CLA 2010-05-07 12:45:08 EDT
Patch applied, Fixed