Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311722 - E4XMIResource's getUniqueId() is implemented incorrectly
Summary: E4XMIResource's getUniqueId() is implemented incorrectly
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 09:48 EDT by Remy Suen CLA
Modified: 2010-05-05 09:49 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-05-05 09:48:21 EDT 
private String getUniqueId() {
  String id = createId();
  while (objectMap.get(id) != null) {
    id = createId();
  }
  return id;
}

Here, 'objectMap' is a Map<EObject, String> but we use a String as a key. This is obviously wrong.
Comment 1 Remy Suen CLA 2010-05-05 09:49:27 EDT 
Thanks for catching this, Tom.